Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAT-368: removed unused files #244

Merged
merged 3 commits into from
Apr 28, 2024

Conversation

Claudenw
Copy link
Contributor

This is a partial clean up as specified in RAT-368
The files :

  • FullTestMatchingLicense – used in old style license definition
  • SimplePatternBasedLicense – used in old style license definition

Are retained as they are marked as deprecated in 0.16 and will be removed in 0.18

@Claudenw Claudenw self-assigned this Apr 25, 2024
@Claudenw
Copy link
Contributor Author

@ottlinger @jbonofre if neither of you see any issues I'll go ahead and merge this.

@ottlinger
Copy link
Contributor

Go ahead - I'm not sure if any of these classes are referenced in the docs ..... @Claudenw

@ottlinger
Copy link
Contributor

Could you add a changelog entry as well to announce that which classes may be removed in 0.18.0?

Copy link
Contributor

@ottlinger ottlinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the reference in docs everything is good to go :)

@Claudenw
Copy link
Contributor Author

verified that removed files are not mentioned in documentation.

@Claudenw Claudenw merged commit 905662d into apache:master Apr 28, 2024
16 checks passed
@Claudenw Claudenw deleted the RAT-368_remove_unused_files branch April 28, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants