[CURATOR-477] add support for configuring Zk Watches #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please open a Jira issue for this. See here - https://cwiki.apache.org/confluence/display/CURATOR/Submitting+Pull+Requests - then maybe @dragonsinth can take a look at this. |
|
@Randgalt the use case makes sense, but there's actually no TreeCache changes in this PR, it's all Framework stuff. |
ramaraochavali
changed the title
|
@Randgalt Created JIRA issue https://issues.apache.org/jira/browse/CURATOR-477. Please let me know if any thing else needs to be done. Please review and let me know if any changes are required. |
|
@Randgalt @dragonsinth on a second thought, I think just cleaner to it at the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our use case, we use
TreeCacheto get Zk Data periodically. We startTreeCacheread data and close it. In this use case, TheZkWatchManagerofZooKeeperclass keeps growing for every TreeCache operation because newTreeNodeobjects are created and added there leading to a memory leak. Also since we do not want the Watcher to periodically watch, this creates unnecessary background operations.In this PR, Made the createZkWatches configurable in the Builder, so that use cases like ours can set it to false. The default is true, retaining the current behaviour.