Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CURATOR-502] Update guava-version to 27.0.1 #302

Closed
wants to merge 1 commit into from

Conversation

dawinter
Copy link

No description provided.

@Randgalt
Copy link
Member

This doesn't compile for me - I get a ton of errors. Also, please rename the PR so that to something like: [CURATOR-502] Update guava-version to 27.0.1

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it 27.0.1-jre?

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is the wrong version

@eolivelli
Copy link
Contributor

@Randgalt as guava has a lot of issues about forward/backward compatibility, did you ever consider to shade it and relocate packages?

@Randgalt
Copy link
Member

It already is shaded. see here: https://github.com/apache/curator/blob/master/curator-client/pom.xml#L90

@eolivelli
Copy link
Contributor

Ops. Sorry.
I didn't notice.

@Randgalt
Copy link
Member

TBH - this PR is not needed. But, we keep getting requests for it so I'm OK with making the change. But, it's not trivial. Several parts of the codebase need to be updated.

@Randgalt
Copy link
Member

@eolivelli
Copy link
Contributor

@Randgalt thanks for the pointer.
Is there any roadmap towards breaking the API and drop Guava classes at least from the public surface of the project?

@Randgalt
Copy link
Member

Not at this time. It would be pretty disruptive and there hasn't been a call for it. But, if someone proposes something it will definitely be considered.

@dawinter dawinter changed the title Update guava-version to 27.0.1 CURATOR-502 Update guava-version to 27.0.1 Jan 29, 2019
@dawinter dawinter changed the title CURATOR-502 Update guava-version to 27.0.1 [CURATOR-502] Update guava-version to 27.0.1 Jan 29, 2019
@Randgalt
Copy link
Member

This can be closed in favor of #301

@dawinter
Copy link
Author

Sure, everything that's update the version is ok for me.

@dawinter dawinter closed this Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants