CURATOR-634: Re-introduce TravisCI for testing on Linux ARM64 #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
This way it won't be checked by maven-rat-plugin Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
martin-g
force-pushed
the
build-on-linux-arm64
branch
from
4dbbb6b
to
922d524
Compare
|
Any feedback on the proposal to (re-)use TravisCI for testing on Linux ARM64 ? |
|
I'm unfamiliar with how the old Travis CI set up. Thus cc @Randgalt @eolivelli please take a look. |
tisonkun
reviewed
Jul 5, 2022
| arch: arm64-graviton2 | ||
| group: edge | ||
| virt: vm | ||
| language: generic |
There was a problem hiding this comment.
Suggested change
| language: generic | |
| language: java |
Why not use a java env? In this approach you don't have to install maven manually.
|
Because this way it will use a rather old version of Maven. I don't
remember now whether Curator uses maven-enforcer-plugin or not.
…On Tue, Jul 5, 2022, 18:21 tison ***@***.***> wrote:
***@***.**** commented on this pull request.
@martin-g <https://github.com/martin-g> I learn more about running travis
tasks on Apache projects recently and agree that this patch is good to
merge. Comments inline.
------------------------------
In .travis.yml
<#412 (comment)>:
> +#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+os: linux
+dist: focal
+arch: arm64-graviton2
+group: edge
+virt: vm
+language: generic
⬇️ Suggested change
-language: generic
+language: java
Why not use a java env? In this approach you don't have to install maven
manually.
—
Reply to this email directly, view it on GitHub
<#412 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABYUQRMS5NC4OQDG4VABFTVSRHHRANCNFSM5PQQJA4Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@martin-g Perhaps you can introduce a maven wrapper in curator repository first. It will be a good solution for such issues. |
|
I'd rather just close the PR than play that limbo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.