Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CXFXJC-41: Regression with JAXB 2.3.5 / 3.x: http://schemas.xmlsoap.org/wsdl/ is not a part of this compilation #11

Merged
merged 2 commits into from
Jan 11, 2022
Merged

CXFXJC-41: Regression with JAXB 2.3.5 / 3.x: http://schemas.xmlsoap.org/wsdl/ is not a part of this compilation #11

merged 2 commits into from
Jan 11, 2022

Conversation

reta
Copy link
Member

@reta reta commented Jan 9, 2022 •
edited
Loading

Interesting regression has been observed with JAXB 2.3.5 and 3.x: the CXF builds are failing with :

[ERROR] rt\wsdl\src\test\resources\schemas\wsdl\test-conf.xjb [25:88]: "http://schemas.xmlsoap.org/wsdl/" is not a part of this compilation. Is this a mistake for "file:core/src/main/resources/schemas/wsdl/wsdl.xsd"?                                                                                
com.sun.istack.SAXParseException2; systemId: file:/rt/wsdl/src/test/resources/schemas/wsdl/test-conf.xjb; lineNumber: 25; columnNumber: 88; "http://schemas.xmlsoap.org/wsdl/" is not a part of this compilation. Is this a mistake for "file:core/src/main/resources/schemas/wsdl/wsdl.xsd"?           
        at com.sun.tools.xjc.reader.internalizer.Internalizer.reportError(Internalizer.java:570)                                                                                                         
        at com.sun.tools.xjc.reader.internalizer.Internalizer.reportError(Internalizer.java:563)                                                                                                         
        at com.sun.tools.xjc.reader.internalizer.Internalizer.buildTargetNodeMap(Internalizer.java:206)                                                                                                  
        at com.sun.tools.xjc.reader.internalizer.Internalizer.buildTargetNodeMap(Internalizer.java:335)                                                                                                  
        at com.sun.tools.xjc.reader.internalizer.Internalizer.transform(Internalizer.java:116)                                                                                                           
        at com.sun.tools.xjc.reader.internalizer.Internalizer.transform(Internalizer.java:77)                                                                                                            
        at com.sun.tools.xjc.reader.internalizer.DOMForest.transform(DOMForest.java:429)                                                                                                                 
        at com.sun.tools.xjc.ModelLoader.buildDOMForest(ModelLoader.java:286)                                                                                                                            
        at com.sun.tools.xjc.ModelLoader.loadXMLSchema(ModelLoader.java:318)                                                                                                                             
        at com.sun.tools.xjc.ModelLoader.load(ModelLoader.java:121)                                                                                                                                      
        at com.sun.tools.xjc.ModelLoader.load(ModelLoader.java:76)                                                                                                                                       
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)                                                                                                                
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)                                                                                              
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)                                                                                      
        at java.base/java.lang.reflect.Method.invoke(Method.java:568)                                                                                                                                    
        at org.apache.cxf.maven_plugin.XSDToJavaRunner.loadModel(XSDToJavaRunner.java:224)                                                                                                               
        at org.apache.cxf.maven_plugin.XSDToJavaRunner.run(XSDToJavaRunner.java:174)                                                                                                                     
        at org.apache.cxf.maven_plugin.XSDToJavaRunner.main(XSDToJavaRunner.java:360)                                                                                                                                                                                                         
        at org.apache.cxf.maven_plugin.XSDToJavaRunner.loadModel(XSDToJavaRunner.java:224)                                                                                                               
        at org.apache.cxf.maven_plugin.XSDToJavaRunner.run(XSDToJavaRunner.java:174)                                                                                                                     
        at org.apache.cxf.maven_plugin.XSDToJavaRunner.main(XSDToJavaRunner.java:360)

It turned out, it is related to the change of how systemId is being passed through: previously, it was passed along with the InputSource in DOMForest by calling this method:

    /**
     * Parses an XML at the given location (
     * and XMLs referenced by it) into DOM trees
     * and stores them to this forest.
     * 
     * @return the parsed DOM document object.
     */
    public Document parse( String systemId, boolean root ) throws SAXException, IOException {
        ... 
        // but we still use the original system Id as the key.
        return parse( systemId, is, root );
    }

But the latest runtimes were changed to use this method instead:

    public Document parse( InputSource source, boolean root ) throws SAXException {
        if( source.getSystemId()==null )
            throw new IllegalArgumentException();
        
        return parse( source.getSystemId(), source, root );
    }

As the result, the systemId was stopped to resolve in certain cases. I am working on adding the test case, but it is not trivial.

@reta reta requested a review from amarkevich January 9, 2022 16:28
ffang
ffang approved these changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@ffang ffang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@reta reta merged commit b08212c into apache:master Jan 11, 2022
reta added a commit that referenced this pull request Jan 11, 2022
@reta
CXFXJC-41: Regression with JAXB 2.3.5 / 3.x: http://schemas.xmlsoap.o…
059fac2 
…rg/wsdl/ is not a part of this compilation (#11)

* CXFXJC-41: Regression with JAXB 2.3.5 / 3.x: http://schemas.xmlsoap.org/wsdl/ is not a part of this compilation

* CXFXJC-41: Added a test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffang ffang ffang approved these changes

@amarkevich amarkevich Awaiting requested review from amarkevich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@reta @ffang