CXFXJC-47: XJC DefaultValue plugin uses JAXBElement that does not have a default constructor

[marcelhdl]

We've found a minor bug when using extensions and substitiongroups.
The defaultvalue-plugin generates a new JAXBElement expression, which isn't valid java code, as JAXBElement does not have a default constructor.
I've added a fix and a xsd-file for the corresponding test, to reproduce this bug.

[reta]

@marcelhdl thank you bringing this issue, we probably should step further and detect such cases in the plugin by verifying if the default constructor exists. Would you be willing to make this change? Thank you!

[marcelhdl]

@reta I just gave it a try, but while trying it out - i got stuck. I guess we don't know if there are default-constructors for each class because we aren't having all of them in the classpath at runtime.
We need a JType which extends JDefinedClass to check for the available constructors, but we got a simple JClass (JNarrowedClass) here.

[reta]

@reta I just gave it a try, but while trying it out - i got stuck. I guess we don't know if there are default-constructors for each class because we aren't having all of them in the classpath at runtime.

I see, thank you @marcelhdl , may be whitelisting could be better here (for JAXB classes at least): it seems like no matter what, for JAXBElement we could not generate the default value (configuration looks a bit redundant in this case). Thank you.

[marcelhdl]

@reta sorry for my late response, i am runnning out of time atm.
Is it possible that you implement the whitelisting here? Otherwise this bug must wait.

[reta]

@reta sorry for my late response, i am runnning out of time atm.

Not a problem @marcelhdl , thank you a lot for spending your time on that, I will pick it up shortly, looks like an issue worth fixing.

[marcelhdl]

Hi @reta, how is it going.
Did you have the time already to check that issue. we are now starting with jakarta and do also have issues here.
So we would need the fix for 3.3.3 und 4.0.1.

[reta]

Hi @reta, how is it going.

Hey @marcelhdl , slipped through my list, will wrapping it up shortly, sorry about that

[marcelhdl]

@reta Looks good to me :)
How are the changes going into 3.x also?
Another Pull Request?

[reta]

@reta Looks good to me :)

Thank you @marcelhdl , I will backport that to all maintenance branches once merged (a bit later today I hope)

[marcelhdl]

@reta this would be awesome!!

[marcelhdl]

@reta do you already know when the two new versions are released?

[reta]

@reta do you already know when the two new versions are released?

@marcelhdl there is no ETA as of today, but hopefully soon enough

[marcelhdl]

@reta thanks for the quick response.
I hope so too. Do you need some support with backporting the fix?

[reta]

I hope so too. Do you need some support with backporting the

No, thank you @marcelhdl , it is already in 4.0.x and 3.3.x branches

[marcelhdl]

Hi @reta, any news on the ETA?

[reta]

Hi @reta, any news on the ETA?

Hi @marcelhdl , we have just cut Apache CXF releases, I think we should be able to make one for cxf-xjc-utils shortly, thank you