CXF-8597: CXF JAXRS client not closing HTTP connections #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reta
commented
Sep 17, 2021
rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/impl/ResponseImpl.java
Outdated
Show resolved
Hide resolved
reta
force-pushed
the
CXF-8597
branch
2 times, most recently
from
b9a40c6
to
4fbc05e
Compare
reta
commented
Sep 20, 2021
| @@ -55,7 +55,6 @@ | |||
| import javax.ws.rs.ext.ReaderInterceptor; | |||
| import javax.ws.rs.ext.RuntimeDelegate.HeaderDelegate; | |||
| import javax.xml.stream.XMLStreamReader; | |||
| import javax.xml.transform.Source; | |||
There was a problem hiding this comment.
Should javax.xml.transform.Source be part of the JAXRSUtils::isStreamingOutType ?
andymc12
approved these changes
Sep 22, 2021
reta
added a commit
that referenced
this pull request
Sep 24, 2021
* CXF-8597: CXF JAXRS client not closing HTTP connections * Added test case for generic WebClient flow * Added test case for generic JAXRSClientFactoryBean / proxy flow (cherry picked from commit d6a449a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #697, the entity input stream is indeed not closed after consumption. But according to the specification for
public abstract <T> T readEntity(Class<T> entityType, Annotation[] annotations):