-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify Daffodil version at one location #74
Comments
shanedell
referenced
this issue
in shanedell/daffodil-vscode
Jan 20, 2022
- Add "daffodilVersion" entry to package.json - Update build.sbt to get daffodilVersion by reading the package.json - Update the extension to have a method for getting the daffodilVersion from the package.json - Create unit test for extension that it gets the proper daffodilVersion given a file path - Fix bash and bat templates to not hard code the app classpath - Had to make new variable inside of the templates, that would be sent for the adding of debug classpaths to the app classpath. As app classpath is a READ only variable Closes #74 Closes #75
shanedell
referenced
this issue
in shanedell/daffodil-vscode
Feb 1, 2022
- Add "daffodilVersion" entry to package.json - Update build.sbt to get daffodilVersion by reading the package.json - Update the extension to have a method for getting the daffodilVersion from the package.json - Create unit test for extension that it gets the proper daffodilVersion given a file path - Fix bash and bat templates to not hard code the app classpath - Had to make new variable inside of the templates, that would be sent for the adding of debug classpaths to the app classpath. As app classpath is a READ only variable Closes #74 Closes #75
shanedell
added a commit
that referenced
this issue
Feb 2, 2022
- Add "daffodilVersion" entry to package.json - Update build.sbt to get daffodilVersion by reading the package.json - Update the extension to have a method for getting the daffodilVersion from the package.json - Create unit test for extension that it gets the proper daffodilVersion given a file path - Fix bash and bat templates to not hard code the app classpath - Had to make new variable inside of the templates, that would be sent for the adding of debug classpaths to the app classpath. As app classpath is a READ only variable Closes #74 Closes #75
stevedlawrence
pushed a commit
to stevedlawrence/daffodil-vscode
that referenced
this issue
Feb 10, 2022
* merge hexview types with daffodil types module * add config event interface * use config event to provide data file config to the hex view * remove another reference to .dataFile * remove stray comment * clarify comment and remove async * remove the write of the .dataFile from the data command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently we specify the Daffodil version for SBT in
build.sbt
and for the backend artifact unpacker indaffodilDebugger.ts
.This duplication has proven to be error prone and could be eliminated by adding an entry to
package.json
and then reading it out in each place.The text was updated successfully, but these errors were encountered: