-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: CometReader.loadVector should not overwrite dictionary ids #476
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #476 +/- ##
============================================
- Coverage 34.05% 34.03% -0.02%
Complexity 859 859
============================================
Files 116 117 +1
Lines 38680 38696 +16
Branches 8568 8567 -1
============================================
Hits 13171 13171
- Misses 22746 22762 +16
Partials 2763 2763 ☔ View full report in Codecov by Sentry. |
common/src/main/scala/org/apache/arrow/c/CometSchemaImporter.scala
Outdated
Show resolved
Hide resolved
common/src/main/scala/org/apache/spark/sql/comet/util/Utils.scala
Outdated
Show resolved
Hide resolved
|
c5e4f91
to
4678304
Compare
4678304
to
0bc4933
Compare
@sunchao Any more comments? Thanks. |
Merged. Thanks @andygrove @sunchao |
Which issue does this PR close?
Closes #475.
Rationale for this change
What changes are included in this PR?
How are these changes tested?