Incorporate upstream array_slice fixes #670
Labels
bug
Something isn't working
Comments
Michael-J-Ward
added a commit
to Michael-J-Ward/datafusion-python
that referenced
this issue
May 10, 2024
This is the same underlying issue as apache#670. The new datafusion UDF functions don't properly handle optional arguments.
Michael-J-Ward
added a commit
to Michael-J-Ward/datafusion-python
that referenced
this issue
May 10, 2024
This is the same underlying issue as apache#670. The new datafusion UDF functions don't properly handle optional arguments.
1 task
Michael-J-Ward
added a commit
to Michael-J-Ward/datafusion-python
that referenced
this issue
May 11, 2024
test_array_functions now has 56 passing test cases and 1 expected failure (`array_slice` being the expected failure Ref apache#670). test_array_function_flatten was broken out as a single test because it was an outlier in terms of test-input. test_array_function_obj_tests had a different set of asserts, so was broken out for 5 test cases. Ref apache#671
Michael-J-Ward
added a commit
to Michael-J-Ward/datafusion-python
that referenced
this issue
May 11, 2024
test_array_functions now has 56 passing test cases and 1 expected failure (`array_slice` being the expected failure Ref apache#670). test_array_function_flatten was broken out as a single test because it was an outlier in terms of test-input. test_array_function_obj_tests had a different set of asserts, so was broken out for 5 test cases. Ref apache#671
Michael-J-Ward
added a commit
to Michael-J-Ward/datafusion-python
that referenced
this issue
May 13, 2024
test_array_functions now has 56 passing test cases and 1 expected failure (`array_slice` being the expected failure Ref apache#670). test_array_function_flatten was broken out as a single test because it was an outlier in terms of test-input. test_array_function_obj_tests had a different set of asserts, so was broken out for 5 test cases. Ref apache#671
Michael-J-Ward
added a commit
to Michael-J-Ward/datafusion-python
that referenced
this issue
May 15, 2024
test_array_functions now has 56 passing test cases and 1 expected failure (`array_slice` being the expected failure Ref apache#670). test_array_function_flatten was broken out as a single test because it was an outlier in terms of test-input. test_array_function_obj_tests had a different set of asserts, so was broken out for 5 test cases. Ref apache#671
Michael-J-Ward
added a commit
to Michael-J-Ward/datafusion-python
that referenced
this issue
May 15, 2024
test_array_functions now has 56 passing test cases and 1 expected failure (`array_slice` being the expected failure Ref apache#670). test_array_function_flatten was broken out as a single test because it was an outlier in terms of test-input. test_array_function_obj_tests had a different set of asserts, so was broken out for 5 test cases. Ref apache#671
andygrove
pushed a commit
that referenced
this issue
May 23, 2024
test_array_functions now has 56 passing test cases and 1 expected failure (`array_slice` being the expected failure Ref #670). test_array_function_flatten was broken out as a single test because it was an outlier in terms of test-input. test_array_function_obj_tests had a different set of asserts, so was broken out for 5 test cases. Ref #671
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Upgrading in #669 discovered a few bugs in
datafusionBlocked on
array_slicepanics withstride=1datafusion#10425strideis not optional for newarray_sliceUDF datafusion#10424So we commented out a single failing test to make the tests pass.
eeccbfd
TODO
Once the upstream fixes are available
strideinfunctions::array_sliceThe text was updated successfully, but these errors were encountered: