Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Expand tests for built-in functions #129

Merged
merged 5 commits into from
Jan 24, 2023

Conversation

simicd
Copy link
Contributor

@simicd simicd commented Jan 15, 2023

Which issue does this PR close?

Closes #128

Rationale for this change

Improve test coverage for buit-in functions

What changes are included in this PR?

  • Expand tests for math functions
  • Expand tests for string functions
  • Expand tests for hash functions
  • Add tests for temporal functions

Are there any user-facing changes?

No

@simicd
Copy link
Contributor Author

simicd commented Jan 19, 2023

Thanks for running the GitHub Action, saw it was failing yesterday.

  • Rebased branch to latest master
  • Fix failing unit tests (change in data types)
  • Ran formatter & linter so that GitHub Action job should pass now

@jdye64
Copy link
Contributor

jdye64 commented Jan 20, 2023

@simicd I don't have permissions to officially review but wanted to say changes look good. More test coverage is always a good thing

@simicd
Copy link
Contributor Author

simicd commented Jan 20, 2023

Thanks @jdye64! One question: When you want to update a branch after submitting a PR, do you rebase or just merge main into your branch? Asking because it seems like Actions require someone to trigger the workflow again, hope I didn't pick the wrong option by rebasing.

@martin-g
Copy link
Member

I always prefer using git rebase for Pull Request branches. This way the commit history is cleaner.
Rebasing also makes it easier to use Squash and merge Github UI functionality.

The workflows should be triggered manually for first time contributors. Once your first PR is merged all following PRs will execute the checks automatically!

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @simicd

@simicd
Copy link
Contributor Author

simicd commented Jan 22, 2023

Thanks for the review @andygrove and for the explanation @martin-g!

@andygrove andygrove merged commit da3a072 into apache:main Jan 24, 2023
@simicd simicd deleted the test/function-unit-tests branch January 28, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand unit tests for built-in functions
4 participants