Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Window functions #182

Merged
merged 2 commits into from
Feb 15, 2023
Merged

test: Window functions #182

merged 2 commits into from
Feb 15, 2023

Conversation

simicd
Copy link
Contributor

@simicd simicd commented Feb 15, 2023

Which issue does this PR close?

Closes #72
Closes #135

Rationale for this change

Confirm window functions work by adding unit tests.

What changes are included in this PR?

Are there any user-facing changes?

n/a

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @simicd. I didn't verify that the expected results are correct, but LGTM.

@andygrove andygrove merged commit d51c54d into apache:main Feb 15, 2023
@simicd
Copy link
Contributor Author

simicd commented Feb 15, 2023

Thanks for the review @andygrove!

@simicd simicd deleted the test/window-functions branch February 26, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

window_lead test appears to be non-deterministic EPIC: Add all functions to python binding functions
2 participants