Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Regr to UDAF #10883

Closed
jayzhan211 opened this issue Jun 12, 2024 · 1 comment · Fixed by #10898
Closed

Convert Regr to UDAF #10883

jayzhan211 opened this issue Jun 12, 2024 · 1 comment · Fixed by #10898
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jayzhan211
Copy link
Contributor

Is your feature request related to a problem or challenge?

Similar to other issues in #8708 Move Regr in datafusion/physical-expr/src/aggregate/regr.rs to datafusion/functions-aggregate/src/regr.rs

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response
@jayzhan211 jayzhan211 added enhancement New feature or request good first issue Good for newcomers labels Jun 12, 2024
@jayzhan211 jayzhan211 mentioned this issue Jun 12, 2024
Open
@eejbyfeldt
Copy link
Contributor

Will have a go on this one.

eejbyfeldt added a commit to eejbyfeldt/datafusion that referenced this issue Jun 13, 2024
@eejbyfeldt
Move Regr_* functions to use UDAF
51ff8a2 
Closes apache#10883 and is part of apache#8708
@eejbyfeldt eejbyfeldt mentioned this issue Jun 13, 2024
Merged
findepi pushed a commit to findepi/datafusion that referenced this issue Jul 16, 2024
@eejbyfeldt @alamb @findepi
Move Regr_* functions to use UDAF (apache#10898)
8911223 
* Move Regr_* functions to use UDAF

Closes apache#10883 and is part of apache#8708

* Format and regen

* tweak error check

---------

Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move Regr_* functions to use UDAF eejbyfeldt/datafusion
2 participants
@jayzhan211 @eejbyfeldt