Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serde support for CSV FileTypeWriterOptions #8597

Closed
andygrove opened this issue Dec 20, 2023 · 3 comments · Fixed by #8641
Closed

Add serde support for CSV FileTypeWriterOptions #8597

andygrove opened this issue Dec 20, 2023 · 3 comments · Fixed by #8641
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@andygrove
Copy link
Member

Is your feature request related to a problem or challenge?

DataFusion supports many FileTypeWriterOptions:

pub enum FileTypeWriterOptions {
    #[cfg(feature = "parquet")]
    Parquet(ParquetWriterOptions),
    CSV(CsvWriterOptions),
    JSON(JsonWriterOptions),
    Avro(AvroWriterOptions),
    Arrow(ArrowWriterOptions),
}

The serde support in the datafusion-proto crate currently only supports JSON:

message FileTypeWriterOptions {
  oneof FileType {
    JsonWriterOptions json_options = 1;
  }
}

Describe the solution you'd like

Add serde support for CSV FileTypeWriterOptions

Describe alternatives you've considered

No response

Additional context

No response

@devinjdangelo
Copy link
Contributor

I am interested in helping out with this (and the related FileTypeWriterOption / copy serde support issues). I can take a look later today or tomorrow if you aren't too far along already.

@andygrove
Copy link
Member Author

andygrove commented Dec 23, 2023

I am interested in helping out with this (and the related FileTypeWriterOption / copy serde support issues). I can take a look later today or tomorrow if you aren't too far along already.

Sorry, just saw this message, and I have a draft PR up for this one now. Would be great to get your review and also would be good to work with you on this.

Would you be interested in picking up #8632?

@devinjdangelo
Copy link
Contributor

@andygrove Yes, I can take a look at the draft PR, and happy to pick up #8632 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants