Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix datafusion-cli cursor isn't on the right position in windows 7 cmd #10028

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

colommar
Copy link
Contributor

Which issue does this PR close?

Closes #9501

Rationale for this change

maybe the root of the problem is the prompt ❯ is a utf-8 character, it occupied multi-bytes, suggest use an ASCII charactor, such as >

What changes are included in this PR?

change all into >

Are these changes tested?

Are there any user-facing changes?

when using the datafusion-cli, instead of ❯ select g(enerate_series(1,10);, they will get >select g(enerate_series(1,10);

@github-actions github-actions bot added logical-expr Logical plan and expressions optimizer Optimizer rules core Core datafusion crate labels Apr 10, 2024
@alamb alamb changed the title fix#9501 Fix datafusion-cli cursor isn't on the right position in windows 7 cmd Apr 10, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Thank you @colommar

Any thoughts @jimexist ?

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks simpler to me. Thanks @colommar

@alamb alamb merged commit feb9100 into apache:main Apr 11, 2024
26 checks passed
appletreeisyellow pushed a commit to influxdata/arrow-datafusion that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core datafusion crate logical-expr Logical plan and expressions optimizer Optimizer rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

datafusion-cli cursor isn't on the right position in windows 7 cmd
3 participants