Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change output name of CAST expressions #3328

Closed
wants to merge 9 commits into from

Conversation

andygrove
Copy link
Member

Which issue does this PR close?

Closes #3326

Rationale for this change

Match Postgres and Spark behavior, where a CAST does not rename an expression

What changes are included in this PR?

Change physical name of CAST

Are there any user-facing changes?

No

@andygrove andygrove changed the title Change name of physical CAST expression Change output name of physical CAST expression Sep 1, 2022
@andygrove andygrove marked this pull request as draft September 1, 2022 15:58
@andygrove andygrove changed the title Change output name of physical CAST expression Change output name of CAST expressions Sep 1, 2022
@github-actions github-actions bot added the logical-expr Logical plan and expressions label Sep 1, 2022
@github-actions github-actions bot added the optimizer Optimizer rules label Sep 2, 2022
@andygrove
Copy link
Member Author

This is turning out to be more complex and nuanced than I had realized.

@andygrove andygrove closed this Sep 3, 2022
@andygrove andygrove deleted the cast-physical-name branch January 27, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core datafusion crate logical-expr Logical plan and expressions optimizer Optimizer rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CAST should not change the name of an expression
1 participant