Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move common code used for testing code into datafusion/test_utils #3961

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Oct 25, 2022

Which issue does this PR close?

Closes #3960

Rationale for this change

I want to reuse this code

See more detail on #3960

What changes are included in this PR?

Consolidate code that is helpful for testing into a test_utils crate:

  1. "fuzz_utils"
  2. A data generator for access-log like data

Are there any user-facing changes?

No -- this just moves code around

@github-actions github-actions bot added the core Core datafusion crate label Oct 25, 2022
@alamb alamb changed the title Alamb/consolidate test utils Put common code used for testing code into datafusion/test_utils Oct 25, 2022
@alamb alamb changed the title Put common code used for testing code into datafusion/test_utils Move common code used for testing code into datafusion/test_utils Oct 26, 2022
@alamb
Copy link
Contributor Author

alamb commented Oct 27, 2022

I wonder if @xudong963 or @Ted-Jiang has a few minutes to review this too (I think it is fairly straightforward)

Copy link
Member

@xudong963 xudong963 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andygrove andygrove merged commit 8792a01 into apache:master Oct 27, 2022
@ursabot
Copy link

ursabot commented Oct 27, 2022

Benchmark runs are scheduled for baseline = 6860ae4 and contender = 8792a01. 8792a01 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb
Copy link
Contributor Author

alamb commented Oct 27, 2022

Thanks @xudong963 !

@alamb alamb deleted the alamb/consolidate_test_utils branch October 27, 2022 20:29
Dandandan pushed a commit to yuuch/arrow-datafusion that referenced this pull request Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core datafusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Put common code used for testing code into datafusion/test_utils.rs
4 participants