Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix negative interval parsing bug #4238

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

Jefffrey
Copy link
Contributor

@Jefffrey Jefffrey commented Nov 16, 2022

Which issue does this PR close?

Closes #4237.

Rationale for this change

What changes are included in this PR?

Ensure correctly discarding high bits of components of IntervalDayTime and IntervalMonthDayNano before combining them with bitwise operations into single integer

Are these changes tested?

Added additional user tests

Are there any user-facing changes?

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Jefffrey

@alamb alamb merged commit 905935c into apache:master Nov 16, 2022
@alamb
Copy link
Contributor

alamb commented Nov 16, 2022

Thanks @Jefffrey and @viirya and @andygrove -- it is great to see the momentum here

@ursabot
Copy link

ursabot commented Nov 16, 2022

Benchmark runs are scheduled for baseline = 75ef194 and contender = 905935c. 905935c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@Jefffrey Jefffrey deleted the 4237_negative_intervals_bug branch November 16, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug parsing interval with negative values
5 participants