Remove Ballista DataFrame #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
==========================================
+ Coverage 76.24% 76.36% +0.11%
==========================================
Files 134 134
Lines 23051 23017 -34
==========================================
Hits 17576 17576
+ Misses 5475 5441 -34
Continue to review full report at Codecov.
|
|
@alamb @jorgecarleitao Any objection to me merging this one? |
jorgecarleitao
approved these changes
Apr 25, 2021
for me 👍
alamb
pushed a commit
that referenced
this pull request
Jun 14, 2022
* chore: default precision and scale for cast decimal improve ok * fix decimal type max precision size (#48) * minor * add tests
waynexia
referenced
this pull request
in waynexia/arrow-datafusion
Jun 20, 2022
* chore: default precision and scale for cast decimal improve ok * fix decimal type max precision size (#48) * minor * add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2
Rationale for this change
One DataFrame implementation is better than two.
What changes are included in this PR?
Are there any user-facing changes?
Yes, users now get DataFusion dataframes from the BallistaContext.
If there are user-facing changes then we may require documentation to be updated before approving the PR.
There isn't really any documentation yet to update.
If there are any breaking changes to public APIs, please add the
breaking changelabel.This is a breaking change but Ballista is < 1.0.0 so expected.