Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: show creation of DFSchema #8132

Merged
merged 2 commits into from
Nov 12, 2023
Merged

docs: show creation of DFSchema #8132

merged 2 commits into from
Nov 12, 2023

Conversation

wjones127
Copy link
Member

Which issue does this PR close?

Closes #8131.

Rationale for this change

I got stuck figuring this out, and noticed there was very little documentation here.

I don't think I yet understand enough about DFSchema to fully document it. For now I'm mostly using unqualified schemas. Therefore, I'm not trying to complete #7724 with this PR.

What changes are included in this PR?

Adds some initial examples.

Are these changes tested?

Examples run with doc tests.

Are there any user-facing changes?

@alamb
Copy link
Contributor

alamb commented Nov 10, 2023

Thank you very much @wjones127

@wjones127 wjones127 marked this pull request as ready for review November 10, 2023 21:59
@wjones127 wjones127 requested a review from alamb November 10, 2023 21:59
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very helpful. Thanks @wjones127

Co-authored-by: Andy Grove <andygrove73@gmail.com>
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution @wjones127 -- I think this will help avoid a bunch of confusion

/// assert!(df_schema.has_column(&column));
/// ```
///
/// # Converting back to Arrow schema
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @wjones127 this is super helpful

@alamb alamb merged commit f67c20f into main Nov 12, 2023
43 checks passed
@alamb alamb deleted the 8131-dfschema-docs branch June 25, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add quick example of creating unqualified DFSchema
3 participants