Minor: Make BuiltInScalarFunction::alias a method
#8349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Nov 28, 2023
There was a problem hiding this comment.
Using whitespace blind diff shows the actual changes to this PR much better in my opinion: https://github.com/apache/arrow-datafusion/pull/8349/files?w=1
crepererum
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #8348
Rationale for this change
I want to have ScalarUDF support aliases, and thus I want to have aliases handled as part of Expr::ScalarFunction rather than a free function. By refactoring
BuiltInScalarFunction::aliasit will make it easier to handle uniformly.What changes are included in this PR?
BuiltInScalarFunction::aliasa functionAre these changes tested?
Covered by existing tests
Are there any user-facing changes?