Added the extra lower bound functions and test #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2635063281
💛 - Coveralls |
tuple/include/tuple_sketch_impl.hpp
Outdated
| @@ -39,16 +39,30 @@ double tuple_sketch<S, A>::get_estimate() const { | |||
| return get_num_retained() / get_theta(); | |||
| } | |||
|
|
|||
| template<typename S, typename A> | |||
| double tuple_sketch<S, A>::get_lower_bound(uint8_t num_std_devs, uint32_t num_subset_entries) const { | |||
| if (is_empty()) num_subset_entries = 0 ; // When the sketch is empty we don't keep information for >0 identifiers. | |||
There was a problem hiding this comment.
I don't think this line is needed. if sketch is empty, get_num_retained() == 0
There was a problem hiding this comment.
I was originally unsure but I think that it is necessary. Suppose the line is not included and the user calls the function on an empty sketch but erroneously includes a num_subset_entries = x for an x > 0. In this case, the sketch is empty, so the function should return 0. However, because the sketch is empty and not in estimation mode, we move to line 46 and return num_subset_entries = x rather than zero. Likewise for the corresponding upper bound function.
There was a problem hiding this comment.
num_subset_entries will be set to 0 by line 45 since min(x, 0) == 0
AlexanderSaydakov
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added extra lower bound functionality for consistency with java api and likewise for upper bound.
Expanded unit testing framework to account for these changes as well.