JIRA DTACLOUD_210

various small GUI improvements: use hyperlinks for FWs and volumes in
instances, allow name to be specified for new volumes, display name
when available, don't use hyperlink for 'unknown' instances,
don't use <--> if no device specified

Patches from Dies Koper diesk@fast.au.fujitsu.com

https://issues.apache.org/jira/browse/DTACLOUD-210

server/lib/deltacloud/drivers/mock/mock_driver.rb

@@ -273,8 +273,10 @@ def create_storage_volume(credentials, opts=nil)
       check_credentials(credentials)
       opts ||= {}
       opts[:capacity] ||= "1"
+      id = "Volume#{Time.now.to_i}"
       volume = {
-            :id => "Volume#{Time.now.to_i}",
+            :id => id,
+            :name => opts[:name] ? opts[:name] : id,
             :created => Time.now.to_s,
             :state => "AVAILABLE",
             :capacity => opts[:capacity],

server/views/instances/show.html.haml

@@ -45,12 +45,14 @@
         %a{ :href => key_url(@instance.keyname), :'data-ajax' => 'false'}=@instance.keyname
     - if @instance.firewalls
       %li{ :'data-role' => 'list-divider'} Firewalls
-      %li=@instance.firewalls.join(", ")
+      - @instance.firewalls.each do |firewall|
+        %li
+          %a{ :href => firewall_url(firewall), :'data-ajax' => 'false'}=firewall
     - if @instance.storage_volumes
       %li{ :'data-role' => 'list-divider'} Attached Storage Volumes
       -@instance.storage_volumes.each do |vol|
         %li
-          %p{ :'data-role' => 'fieldcontain'}="#{vol.keys.first} <---> #{vol.values.first}"
+          %a{ :href => storage_volume_url("#{vol.keys.first}"), :'data-ajax' => 'false'}=["#{vol.keys.first}", "#{vol.values.first}"].compact.reject{ |e| e.empty? }.join(' <---> ')
     %li{ :'data-role' => 'list-divider'} Actions
     %li
       %div{ :'data-role' => 'controlgroup', :'data-type' => "horizontal" }

server/views/storage_volumes/attach.html.haml

@@ -16,4 +16,4 @@
       Device name:
     %input{ :name => "device", :size => 10, :value => "/dev/sdc"}
   %p
-    %input{ :type => :submit, :name => "commit", :value => "create" }/
+    %input{ :type => :submit, :name => "commit", :value => "attach" }/

server/views/storage_volumes/index.html.haml

@@ -8,6 +8,6 @@
       %li
         %a{ :href => storage_volume_url(volume.id), :'data-ajax' => 'false'}
           %img{ :class => 'ui-link-thumb', :src => '/images/volume.png'}
-          %h3= volume.id
+          %h3= volume.name ? volume.name : volume.id
           %p=[volume.realm_id, volume.capacity].join(', ')
           %span{ :class => 'ui-li-count'}=volume.state

server/views/storage_volumes/new.html.haml

@@ -1,6 +1,10 @@
 %h1 Create new storage volume
 
 %form{ :action => storage_volumes_url, :method => :post }
+  %p
+    %label
+      Name:
+    %input{ :name => 'name', :size => 30 } (optional)
   %p
     %label
       Snapshot ID:

server/views/storage_volumes/show.html.haml

@@ -5,7 +5,7 @@
   %ul{ :'data-role' => :listview , :'data-inset' => :true, :'data-divider-theme' => 'd'}
     %li{ :'data-role' => 'list-divider'} Name
     %li
-      %p{ :'data-role' => 'fieldcontain'}=@storage_volume.id
+      %p{ :'data-role' => 'fieldcontain'}=(@storage_volume.name ? @storage_volume.name : @storage_volume.id)
     %li{ :'data-role' => 'list-divider'} Created
     %li
       %p{ :'data-role' => 'fieldcontain'}=@storage_volume.created
@@ -20,8 +20,13 @@
       %p{ :'data-role' => 'fieldcontain'}=@storage_volume.state
     %li{ :'data-role' => 'list-divider'} Attached to
     %li
-      %a{ :href => instance_url( @storage_volume.instance_id)}
-        = @storage_volume.instance_id || 'unknown'
+      - if @storage_volume.instance_id
+        %a{ :href => instance_url( @storage_volume.instance_id)}
+          = @storage_volume.instance_id
+      - elsif @storage_volume.state == "AVAILABLE"
+        %p{ :'data-role' => 'fieldcontain'}= 'none (detached)'
+      -else
+        %p{ :'data-role' => 'fieldcontain'}= 'unknown'
     %li{ :'data-role' => 'list-divider'} Device
     %li
       %p{ :'data-role' => 'fieldcontain'}= @storage_volume.device