[Bug-14378][Master] Trigger task execution in workflow instance page …

…cause workflow instance keep running status (#14389) (cherry picked from commit 64e5741)
apache · Jul 20, 2023 · 397261f · 397261f
1 parent e87db4d
commit 397261f
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/...c/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java b/...c/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java
@@ -2208,14 +2208,14 @@ protected void clearDataIfExecuteTask() {
 
         // remove task instance from taskInstanceMap, completeTaskSet, validTaskMap, errorTaskMap
         // completeTaskSet remove dependency taskInstanceMap, so the sort can't change
-        completeTaskSet.removeIf(set -> {
-            Optional<TaskInstance> existTaskInstanceOptional = getTaskInstance(set);
+        completeTaskSet.removeIf(taskCode -> {
+            Optional<TaskInstance> existTaskInstanceOptional = getTaskInstance(taskCode);
             return existTaskInstanceOptional
-                    .filter(taskInstance -> dag.containsNode(Integer.toString(taskInstance.getId()))).isPresent();
+                    .filter(taskInstance -> dag.containsNode(Long.toString(taskInstance.getTaskCode()))).isPresent();
         });
-        taskInstanceMap.entrySet().removeIf(map -> dag.containsNode(Long.toString(map.getValue().getTaskCode())));
-        validTaskMap.entrySet().removeIf(map -> dag.containsNode(Long.toString(map.getKey())));
-        errorTaskMap.entrySet().removeIf(map -> dag.containsNode(Long.toString(map.getKey())));
+        taskInstanceMap.entrySet().removeIf(entry -> dag.containsNode(Long.toString(entry.getValue().getTaskCode())));
+        validTaskMap.entrySet().removeIf(entry -> dag.containsNode(Long.toString(entry.getKey())));
+        errorTaskMap.entrySet().removeIf(entry -> dag.containsNode(Long.toString(entry.getKey())));
     }
 
     private void saveCacheTaskInstance(TaskInstance taskInstance) {