Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug-14378][Master] Trigger task execution in workflow instance page cause workflow instance keep running status #14389

Merged
merged 1 commit into from Jun 24, 2023

Conversation

Radeity
Copy link
Member

@Radeity Radeity commented Jun 21, 2023

Purpose of the pull request

Brief change log

  • The parameter of dag.containsNode is taskCode, rather taskInstanceId.

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@Radeity Radeity added this to the 3.2.0 milestone Jun 21, 2023
@Radeity Radeity self-assigned this Jun 21, 2023
@Radeity Radeity added 3.2.0 for 3.2.0 version backend and removed backend labels Jun 21, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2023

Codecov Report

Merging #14389 (1ab1d6a) into dev (5cbe170) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 1ab1d6a differs from pull request most recent head aff434c. Consider uploading reports for the commit aff434c to get more accurate results

@@             Coverage Diff              @@
##                dev   #14389      +/-   ##
============================================
- Coverage     38.51%   38.49%   -0.03%     
+ Complexity     4566     4563       -3     
============================================
  Files          1237     1237              
  Lines         43541    43541              
  Branches       4813     4813              
============================================
- Hits          16771    16760      -11     
- Misses        24914    24927      +13     
+ Partials       1856     1854       -2     
Impacted Files Coverage Δ
.../server/master/runner/WorkflowExecuteRunnable.java 10.62% <100.00%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Radeity Radeity added the bug Something isn't working label Jun 21, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun merged commit 64e5741 into apache:dev Jun 24, 2023
46 checks passed
@Radeity Radeity deleted the Bug-14738 branch June 25, 2023 05:03
zhongjiajie pushed a commit that referenced this pull request Jul 20, 2023
…cause workflow instance keep running status (#14389)

(cherry picked from commit 64e5741)
biaoma-ty pushed a commit to Kasma-Inc/dolphinscheduler that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.0 for 3.2.0 version backend bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [Master] Trigger task execution in workflow instance page cause workflow instance keep running status
3 participants