Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][UI] Create a dynamic task component canvas. #12577

Merged
merged 5 commits into from
Oct 28, 2022

Conversation

songjianet
Copy link
Member

Purpose of the pull request

ref #12526

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@songjianet songjianet added feature new feature UI ui and front end related refactor labels Oct 27, 2022
@songjianet songjianet added this to the 4.0.0-alpha milestone Oct 27, 2022
@songjianet songjianet self-assigned this Oct 27, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #12577 (e1979ab) into dev (53340fc) will increase coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev   #12577      +/-   ##
============================================
+ Coverage     39.05%   39.10%   +0.04%     
- Complexity     4175     4191      +16     
============================================
  Files          1044     1044              
  Lines         39289    39447     +158     
  Branches       4501     4530      +29     
============================================
+ Hits          15346    15425      +79     
- Misses        22208    22270      +62     
- Partials       1735     1752      +17     
Impacted Files Coverage Δ
...hinscheduler/api/controller/ProjectController.java 50.00% <0.00%> (-18.43%) ⬇️
...lphinscheduler/api/controller/UsersController.java 55.00% <0.00%> (-3.93%) ⬇️
...er/api/service/impl/TaskDefinitionServiceImpl.java 29.00% <0.00%> (-2.09%) ⬇️
...duler/api/service/impl/WorkerGroupServiceImpl.java 82.20% <0.00%> (-1.87%) ⬇️
...r/plugin/task/sqoop/parameter/SqoopParameters.java 51.19% <0.00%> (-1.20%) ⬇️
...api/service/impl/ProcessDefinitionServiceImpl.java 34.74% <0.00%> (-0.12%) ⬇️
...inscheduler/api/service/impl/UsersServiceImpl.java 70.49% <0.00%> (-0.03%) ⬇️
.../org/apache/dolphinscheduler/api/enums/Status.java 100.00% <0.00%> (ø)
...scheduler/api/service/impl/ProjectServiceImpl.java 62.79% <0.00%> (+1.46%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Oct 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@devosend devosend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@songjianet songjianet merged commit 213bf43 into apache:dev Oct 28, 2022
@songjianet songjianet deleted the feat-dynamic-dag branch October 28, 2022 12:32
hstdream pushed a commit to hstdream/dolphinscheduler that referenced this pull request Nov 2, 2022
* [Feature][UI] Create a dynamic task component canvas.

* [Feature][UI] Create a dynamic task component canvas.

* [Feature][UI] Create a dynamic task component canvas.

* [Feature][UI] Create a dynamic task component canvas.

* [Feature][UI] Create a dynamic task component canvas.
hstdream pushed a commit to hstdream/dolphinscheduler that referenced this pull request Nov 2, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new feature refactor UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants