New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature-14251][Task] Support yarn queue definition in yarn task #14310
Conversation
please check the failed CI, @Radeity |
Codecov Report
@@ Coverage Diff @@
## dev #14310 +/- ##
============================================
- Coverage 38.54% 38.49% -0.06%
+ Complexity 4568 4557 -11
============================================
Files 1241 1239 -2
Lines 43557 43528 -29
Branches 4812 4811 -1
============================================
- Hits 16790 16755 -35
- Misses 24906 24917 +11
+ Partials 1861 1856 -5
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Done, can you help re-run CI :D |
SonarCloud Quality Gate failed. |
Would you like to help review this PR? cc @zhongjiajie @ruanwenjun @rickchengx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM over all
Hi @Radeity do we will remove yarn queue column in table |
I think we should better remove them to keep our codes clean, I will follow up :D |
) (cherry picked from commit 0b69236)
Purpose of the pull request
Queue
.Brief change log
queue
toyarnQueue
.Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md