Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature-14251][Task] Support yarn queue definition in yarn task #14310

Merged
merged 2 commits into from Jul 7, 2023

Conversation

Radeity
Copy link
Member

@Radeity Radeity commented Jun 8, 2023

Purpose of the pull request

Brief change log

  • Modify property name queue to yarnQueue.
  • Add yarn queue input box in UI page of Spark / Flink / MR / DQ tasks.
image

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@rickchengx
Copy link
Contributor

please check the failed CI, @Radeity

@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2023

Codecov Report

Merging #14310 (2c9733f) into dev (1c935d9) will decrease coverage by 0.06%.
The diff coverage is 40.74%.

❗ Current head 2c9733f differs from pull request most recent head cd42315. Consider uploading reports for the commit cd42315 to get more accurate results

@@             Coverage Diff              @@
##                dev   #14310      +/-   ##
============================================
- Coverage     38.54%   38.49%   -0.06%     
+ Complexity     4568     4557      -11     
============================================
  Files          1241     1239       -2     
  Lines         43557    43528      -29     
  Branches       4812     4811       -1     
============================================
- Hits          16790    16755      -35     
- Misses        24906    24917      +11     
+ Partials       1861     1856       -5     
Impacted Files Coverage Δ
...er/master/builder/TaskExecutionContextBuilder.java 66.66% <ø> (-0.58%) ⬇️
.../server/master/runner/WorkflowExecuteRunnable.java 10.17% <0.00%> (-0.01%) ⬇️
.../parameters/dataquality/spark/SparkParameters.java 0.00% <0.00%> (ø)
...lphinscheduler/plugin/task/dq/DataQualityTask.java 0.00% <ø> (ø)
...scheduler/plugin/task/dq/utils/SparkArgsUtils.java 0.00% <0.00%> (ø)
...inscheduler/plugin/task/flink/FlinkStreamTask.java 0.00% <ø> (ø)
...hinscheduler/plugin/task/flink/FlinkConstants.java 0.00% <ø> (ø)
.../dolphinscheduler/plugin/task/flink/FlinkTask.java 0.00% <ø> (ø)
...hinscheduler/plugin/task/spark/SparkConstants.java 0.00% <ø> (ø)
.../dolphinscheduler/plugin/task/spark/SparkTask.java 66.97% <20.00%> (-0.31%) ⬇️
... and 4 more

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Radeity
Copy link
Member Author

Radeity commented Jun 13, 2023

please check the failed CI, @Radeity

Done, can you help re-run CI :D

@sonarcloud
Copy link

sonarcloud bot commented Jun 13, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

42.5% 42.5% Coverage
9.1% 9.1% Duplication

@Radeity
Copy link
Member Author

Radeity commented Jun 14, 2023

Would you like to help review this PR? cc @zhongjiajie @ruanwenjun @rickchengx

@Radeity Radeity self-assigned this Jun 19, 2023
@Radeity Radeity added the 3.2.0 for 3.2.0 version label Jun 19, 2023
@Radeity Radeity added this to the 3.2.0 milestone Jun 19, 2023
Copy link
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM over all

@zhongjiajie zhongjiajie merged commit 0b69236 into apache:dev Jul 7, 2023
46 of 47 checks passed
@zhongjiajie
Copy link
Member

Hi @Radeity do we will remove yarn queue column in table t_ds_queue in the further?

@Radeity Radeity deleted the Feature-14251 branch July 7, 2023 14:02
@Radeity
Copy link
Member Author

Radeity commented Jul 7, 2023

Hi @Radeity do we will remove yarn queue column in table t_ds_queue in the further?

I think we should better remove them to keep our codes clean, I will follow up :D

biaoma-ty pushed a commit to Kasma-Inc/dolphinscheduler that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.0 for 3.2.0 version backend document UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Task] Support yarn queue definition in yarn task
4 participants