[Improvement][Worker] Rename workerZKPath to workerRegistryPath #16144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caicancai
requested review from
caishunfeng,
SbloodyS and
ruanwenjun
as code owners
SbloodyS
reviewed
Jun 13, 2024
caicancai
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #16144 +/- ##
============================================
- Coverage 40.73% 40.70% -0.03%
+ Complexity 5250 5245 -5
============================================
Files 1385 1385
Lines 46109 46109
Branches 4923 4923
============================================
- Hits 18781 18770 -11
- Misses 25401 25412 +11
Partials 1927 1927 ☔ View full report in Codecov by Sentry. |
|
Thank you. Fix |
SbloodyS
approved these changes
Jun 13, 2024
ruanwenjun
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
dolphinscheduler supports several registration services, workerZKPath is misleading and workerRegistryPath is more acceptable
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md