Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][UT] Fix flaky unit test #16151

Merged
merged 4 commits into from
Jun 14, 2024
Merged

[CI][UT] Fix flaky unit test #16151

merged 4 commits into from
Jun 14, 2024

Conversation

SbloodyS
Copy link
Member

@SbloodyS SbloodyS self-assigned this Jun 13, 2024
@SbloodyS SbloodyS added improvement make more easy to user or prompt friendly test 3.3.0 labels Jun 13, 2024
@SbloodyS SbloodyS added this to the 3.3.0 milestone Jun 13, 2024
@github-actions github-actions bot removed the test label Jun 13, 2024
@SbloodyS SbloodyS marked this pull request as draft June 13, 2024 13:37
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.70%. Comparing base (8e53f2f) to head (a7b2a40).

Current head a7b2a40 differs from pull request most recent head ed6a835

Please upload reports for the commit ed6a835 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #16151      +/-   ##
============================================
- Coverage     40.71%   40.70%   -0.01%     
+ Complexity     5247     5245       -2     
============================================
  Files          1385     1385              
  Lines         46109    46109              
  Branches       4923     4923              
============================================
- Hits          18772    18768       -4     
- Misses        25412    25414       +2     
- Partials       1925     1927       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jun 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@SbloodyS SbloodyS marked this pull request as ready for review June 14, 2024 00:38
@ruanwenjun
Copy link
Member

I find the default timeout is 30s, is this small?

@SbloodyS
Copy link
Member Author

I find the default timeout is 30s, is this small?

Yes. So I increase it.

Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun merged commit 8d0202c into apache:dev Jun 14, 2024
63 checks passed
@SbloodyS SbloodyS deleted the fix_flaky_ut branch June 17, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.3.0 backend CI&CD improvement make more easy to user or prompt friendly test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants