Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](grouping)fix grouping function bug #11861

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

starocean999
Copy link
Contributor

@starocean999 starocean999 commented Aug 17, 2022

Proposed changes

Issue Number: close #xxx

Problem summary

the repeat node has the capability to do the expr calculation, no need to throw exception in fe

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added area/planner Issues or PRs related to the query planner kind/test labels Aug 17, 2022
@morrySnow morrySnow requested a review from yangzhg August 22, 2022 04:15
@morrySnow
Copy link
Contributor

@yangzhg PTAL

morrySnow
morrySnow previously approved these changes Aug 23, 2022
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morrySnow
Copy link
Contributor

please rebase to newest master to pass p0 check

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 24, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@yiguolei yiguolei merged commit 8b4f693 into apache:master Aug 24, 2022
wsjz pushed a commit to wsjz/incubator-doris that referenced this pull request Aug 24, 2022
@yiguolei yiguolei mentioned this pull request Aug 26, 2022
Henry2SS pushed a commit to Henry2SS/incubator-doris that referenced this pull request Sep 14, 2022
@yiguolei yiguolei mentioned this pull request Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. area/planner Issues or PRs related to the query planner dev/merge-1.1.2 kind/test reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants