Insert select Stmt keep the same semantics with mysql (#1626) #1628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imay
requested changes
Aug 12, 2019
| @@ -639,6 +639,11 @@ private void handleInsertStmt() throws Exception { | |||
| return; | |||
| } | |||
|
|
|||
| if (insertStmt.getQueryStmt() != null && (coord.getCommitInfos() == null || coord.getCommitInfos().isEmpty())) { | |||
There was a problem hiding this comment.
Because we have already begin a transaction for this insert statement, if you return here now, it will become a pending transaction.
I think that you should abort this transaction before return to user
There was a problem hiding this comment.
Because we have already begin a transaction for this insert statement, if you return here now, it will become a pending transaction.
I think that you should abort this transaction before return to user
add abort operation;
sry ,I habitually performed a git rebase operation
Closed
SWJTU-ZhangLei
pushed a commit
to SWJTU-ZhangLei/incubator-doris
that referenced
this pull request
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.