Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Free olap scanner out of lock #1733

Merged
merged 1 commit into from
Sep 2, 2019
Merged

Free olap scanner out of lock #1733

merged 1 commit into from
Sep 2, 2019

Conversation

imay
Copy link
Contributor

@imay imay commented Sep 2, 2019 •
edited
Loading

This PR will close scanner out of OlapScanner's batch lock,
which will lead all scanners wait for one scanner to finish.

#1726

morningman
morningman approved these changes Sep 2, 2019
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imay imay closed this Sep 2, 2019
@imay imay reopened this Sep 2, 2019
@kangkaisen
Copy link
Contributor

@imay Hi, do you have a benchmark test for this PR?

@imay
Copy link
Contributor Author

imay commented Sep 2, 2019

@imay Hi, do you have a benchmark test for this PR?

@kangkaisen

This only one reason leading to competition.
After this is fixed, competition is not here, but is on the memory alloc/free. So #1732 is used to reduce memory alloc/free.

After they are fixed, concurrency increase twice but BE CPU idle is still high. I will continue to see what is the reason

@kangkaisen
Copy link
Contributor

@imay Hi, do you have a benchmark test for this PR?

@kangkaisen

This only one reason leading to competition.
After this is fixed, competition is not here, but is on the memory alloc/free. So #1732 is used to reduce memory alloc/free.

After they are fixed, concurrency increase twice but BE CPU idle is still high. I will continue to see what is the reason

OK, I see. Thanks you.

@kangkaisen
Copy link
Contributor

+1. LGTM.

@imay imay merged commit 81ca3e3 into apache:master Sep 2, 2019
@imay imay deleted the opt-olap-scan branch September 2, 2019 08:49
@imay imay mentioned this pull request Sep 26, 2019
Closed
SWJTU-ZhangLei pushed a commit to SWJTU-ZhangLei/incubator-doris that referenced this pull request Jul 25, 2023
@w41ter
(selectdb-cloud) Add MS benchmark tool (apache#1733)
ac6520c 
* Add ms benchmark tool
* Add verify command
* Add cloud bench
* Add read-meta and version workload
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morningman morningman morningman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imay @kangkaisen @morningman