Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collect scanner's status when es_http_scan_node close #1861

Merged
merged 4 commits into from
Sep 25, 2019

Conversation

shgxwxl
Copy link
Contributor

@shgxwxl shgxwxl commented Sep 24, 2019

add collect_scanners_status function ,which need to call after start_scanners to check status

@shgxwxl shgxwxl closed this Sep 24, 2019
@shgxwxl shgxwxl reopened this Sep 24, 2019
be/src/exec/es_http_scan_node.cpp Outdated Show resolved Hide resolved
be/src/exec/es_http_scan_node.cpp Outdated Show resolved Hide resolved
@shgxwxl shgxwxl changed the title fix #1859 ut ok collect scanners status when es_http_scan_node close Sep 24, 2019
@shgxwxl shgxwxl changed the title collect scanners status when es_http_scan_node close collect scanner's status when es_http_scan_node close Sep 24, 2019
@shgxwxl
Copy link
Contributor Author

shgxwxl commented Sep 24, 2019

fix #1859
collect all scanners status when es_http_scan_node close
make function collect_scanners_status from public to private
change ut for es_http_scan_node and run ok

call collect_scanners_status before ExecNode::close(state)
Copy link
Contributor

@imay imay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imay imay merged commit c2de62d into apache:master Sep 25, 2019
@imay imay mentioned this pull request Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants