Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enhancement](config) do not abort when a disk is broken #24692

Merged
merged 1 commit into from
Sep 21, 2023
Merged

[enhancement](config) do not abort when a disk is broken #24692

merged 1 commit into from
Sep 21, 2023

Conversation

dataroaring
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@dataroaring
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

yujun777
yujun777 approved these changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@yujun777 yujun777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.42% (8021/22024)
Line Coverage: 28.71% (64370/224244)
Region Coverage: 27.66% (33419/120819)
Branch Coverage: 24.30% (17097/70358)
Coverage Report: http://coverage.selectdb-in.cc/coverage/6d47ab24a174abded5e65cea05bdd668918d0d56_6d47ab24a174abded5e65cea05bdd668918d0d56/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.79 seconds
stream load tsv: 615 seconds loaded 74807831229 Bytes, about 116 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.5 seconds inserted 10000000 Rows, about 338K ops/s
storage size: 17162503872 Bytes

zhannngchen
zhannngchen approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 21, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@dataroaring dataroaring merged commit 4eb09ce into apache:master Sep 21, 2023
26 of 27 checks passed
xiaokang pushed a commit that referenced this pull request Sep 21, 2023
@dataroaring @xiaokang
[enhancement](config) do not abort when a disk is broken (#24692)
aadbefa
@xiaokang xiaokang mentioned this pull request Sep 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yujun777 yujun777 yujun777 approved these changes

@zhannngchen zhannngchen zhannngchen approved these changes

@Yukang-Lian Yukang-Lian Yukang-Lian approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.2-merged p0_b reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dataroaring @doris-robot @yujun777 @zhannngchen @Yukang-Lian @xiaokang