Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore](runtime-filter) enlarge sync filter size rpc timeout limit #37103

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

BiteTheDDDDt
Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt commented Jul 1, 2024

Proposed changes

enlarge sync filter size rpc timeout limit

rf will failed when rpc timeout, so we need enlarge limit

sync filter size meet error, filter: RuntimeFilter: (id = 3, type = in_or_bloomfilter, need_local_merge: false, is_broadcast: false, build_bf_cardinality: true

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

Copy link
Contributor

github-actions bot commented Jul 1, 2024

clang-tidy review says "All clean, LGTM! 👍"

@BiteTheDDDDt BiteTheDDDDt changed the title [Chore](runtime-filter) do not make query failed when sync filter size fail [Chore](runtime-filter) enlarge sync filter size rpc timeout limit Jul 1, 2024
@BiteTheDDDDt
Copy link
Contributor Author

run buildall

Copy link
Contributor

github-actions bot commented Jul 1, 2024

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Jul 2, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jul 2, 2024
Copy link
Contributor

github-actions bot commented Jul 2, 2024

PR approved by anyone and no changes requested.

@BiteTheDDDDt BiteTheDDDDt merged commit fa5e700 into apache:master Jul 2, 2024
28 of 32 checks passed
BiteTheDDDDt added a commit that referenced this pull request Jul 2, 2024
…37103)

## Proposed changes
enlarge sync filter size rpc timeout limit

rf will failed when rpc timeout, so we need enlarge limit
```
sync filter size meet error, filter: RuntimeFilter: (id = 3, type = in_or_bloomfilter, need_local_merge: false, is_broadcast: false, build_bf_cardinality: true
```
BiteTheDDDDt added a commit that referenced this pull request Jul 3, 2024
…37103)

## Proposed changes
enlarge sync filter size rpc timeout limit

rf will failed when rpc timeout, so we need enlarge limit
```
sync filter size meet error, filter: RuntimeFilter: (id = 3, type = in_or_bloomfilter, need_local_merge: false, is_broadcast: false, build_bf_cardinality: true
```
BiteTheDDDDt added a commit to BiteTheDDDDt/incubator-doris that referenced this pull request Jul 3, 2024
update

[Chore](runtime-filter) enlarge sync filter size rpc timeout limit (apache#37103)

enlarge sync filter size rpc timeout limit

rf will failed when rpc timeout, so we need enlarge limit
```
sync filter size meet error, filter: RuntimeFilter: (id = 3, type = in_or_bloomfilter, need_local_merge: false, is_broadcast: false, build_bf_cardinality: true
```

update

update

update

format

[Bug](runtime-filter) fix brpc ctrl use after free and remove apply filter v1 (apache#35186)

fix brpc ctrl use after free and remove apply filter v1

reset

update
dataroaring pushed a commit to dataroaring/incubator-doris that referenced this pull request Jul 5, 2024
…pache#37103)

## Proposed changes
enlarge sync filter size rpc timeout limit

rf will failed when rpc timeout, so we need enlarge limit
```
sync filter size meet error, filter: RuntimeFilter: (id = 3, type = in_or_bloomfilter, need_local_merge: false, is_broadcast: false, build_bf_cardinality: true
```
@yiguolei yiguolei mentioned this pull request Jul 19, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.5-merged dev/3.0.0-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants