-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](HadoopLz4BlockCompression)Fixed the bug that HadoopLz4BlockCompression creates _decompressor every time it decompresses. #37187
Conversation
…ression creates _decompressor every time it decompresses.
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
@@ -25,6 +25,8 @@ | |||
defined(__i386) || defined(_M_IX86) | |||
#include <libdeflate.h> | |||
#endif | |||
#include <glog/log_severity.h> | |||
#include <glog/logging.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: duplicate include [readability-duplicate-include]
be/src/util/block_compression.cpp:27:
- #include <glog/log_severity.h>
- #include <glog/logging.h>
+ #include <glog/log_severity.h>
TPC-H: Total hot run time: 40690 ms
|
TPC-DS: Total hot run time: 174715 ms
|
ClickBench: Total hot run time: 30.42 s
|
run p0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
…ression creates _decompressor every time it decompresses. (#37187) ## Proposed changes Problem: HadoopLz4BlockCompression uses a singleton mode. Every time its decompression function is called, a new object will be created for its member variable _decompressor. In a multi-threaded scenario, new objects will be created for _decompressor at the same time. Fix method: During the construction phase of HadoopLz4BlockCompression, a new object is created for its member variable _decompressor. When calling the decompression function, there is no need to create a new object for _decompressor.
Proposed changes
Problem:
HadoopLz4BlockCompression uses a singleton mode.
Every time its decompression function is called, a new object will be created for its member variable _decompressor. In a multi-threaded scenario, new objects will be created for _decompressor at the same time.
Fix method:
During the construction phase of HadoopLz4BlockCompression, a new object is created for its member variable _decompressor. When calling the decompression function, there is no need to create a new object for _decompressor.
Issue Number: close #xxx