Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](Nereids) constant folding for str_to_date on datev1 is wrong #37360

Merged
merged 1 commit into from
Jul 7, 2024

Conversation

morrySnow
Copy link
Contributor

when enable datev1, we should return datev1/datetimev1

when enable datev1, we should return datev1/datetimev1
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39773 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f2419eb9943bb9e8cfa7d9d8d1a80d911b4415c3, data reload: false

------ Round 1 ----------------------------------
q1	17633	4455	4230	4230
q2	2032	195	188	188
q3	10472	1281	1146	1146
q4	10191	799	747	747
q5	7511	2658	2623	2623
q6	227	138	135	135
q7	949	596	591	591
q8	9222	2063	2095	2063
q9	8982	6472	6521	6472
q10	8883	3708	3723	3708
q11	457	236	235	235
q12	406	222	224	222
q13	17870	2969	2946	2946
q14	265	242	228	228
q15	539	504	499	499
q16	512	375	376	375
q17	964	676	609	609
q18	8086	7445	7420	7420
q19	3664	1582	1515	1515
q20	682	328	349	328
q21	5079	3152	3886	3152
q22	395	341	344	341
Total cold run time: 115021 ms
Total hot run time: 39773 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4339	4282	4215	4215
q2	382	269	260	260
q3	2943	2777	2777	2777
q4	1878	1610	1565	1565
q5	5284	5276	5271	5271
q6	215	128	130	128
q7	2128	1762	1689	1689
q8	3190	3353	3292	3292
q9	8357	8374	8325	8325
q10	3814	3649	3643	3643
q11	591	479	485	479
q12	798	605	646	605
q13	17497	2982	2983	2982
q14	300	256	254	254
q15	516	478	476	476
q16	468	404	439	404
q17	1762	1482	1464	1464
q18	7602	7411	7497	7411
q19	3285	1661	1519	1519
q20	1972	1774	1799	1774
q21	4804	4839	4823	4823
q22	611	555	556	555
Total cold run time: 72736 ms
Total hot run time: 53911 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 172948 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f2419eb9943bb9e8cfa7d9d8d1a80d911b4415c3, data reload: false

query1	911	370	365	365
query2	6461	2499	2303	2303
query3	6642	225	212	212
query4	26188	17432	17469	17432
query5	4188	487	487	487
query6	284	176	173	173
query7	4592	317	286	286
query8	316	301	289	289
query9	8525	2433	2410	2410
query10	618	289	272	272
query11	11567	10212	10151	10151
query12	133	82	81	81
query13	1633	373	358	358
query14	10192	7576	7334	7334
query15	247	186	197	186
query16	7883	300	303	300
query17	1835	534	513	513
query18	1940	267	266	266
query19	196	151	148	148
query20	86	82	78	78
query21	210	132	125	125
query22	4355	4146	4217	4146
query23	33696	33041	33196	33041
query24	12024	2825	2756	2756
query25	648	360	369	360
query26	1773	151	152	151
query27	2958	311	318	311
query28	7417	2094	2080	2080
query29	1085	632	606	606
query30	295	154	145	145
query31	954	713	740	713
query32	96	51	53	51
query33	772	292	300	292
query34	983	481	489	481
query35	737	607	605	605
query36	1078	918	938	918
query37	276	74	77	74
query38	2838	2747	2727	2727
query39	863	790	791	790
query40	287	127	125	125
query41	55	50	52	50
query42	118	101	99	99
query43	593	524	538	524
query44	1255	723	729	723
query45	195	158	157	157
query46	1068	711	697	697
query47	1875	1795	1743	1743
query48	365	296	293	293
query49	1195	445	409	409
query50	771	381	375	375
query51	6840	6834	6795	6795
query52	101	93	90	90
query53	370	288	286	286
query54	959	446	441	441
query55	74	72	73	72
query56	285	275	273	273
query57	1164	1073	1047	1047
query58	254	282	248	248
query59	3377	3385	3003	3003
query60	296	276	272	272
query61	102	120	93	93
query62	636	438	450	438
query63	317	285	290	285
query64	10463	2167	1619	1619
query65	3165	3117	3108	3108
query66	1355	348	333	333
query67	15487	15127	15134	15127
query68	4605	547	532	532
query69	470	335	318	318
query70	1194	1080	1165	1080
query71	400	282	281	281
query72	7207	5863	5637	5637
query73	741	321	322	321
query74	5960	5610	5494	5494
query75	3469	2643	2679	2643
query76	2718	959	930	930
query77	471	308	304	304
query78	11637	9204	8824	8824
query79	5374	514	514	514
query80	1163	503	496	496
query81	598	224	224	224
query82	832	114	106	106
query83	275	183	179	179
query84	290	103	105	103
query85	809	367	372	367
query86	491	335	305	305
query87	3287	3101	3150	3101
query88	4948	2396	2397	2396
query89	483	386	392	386
query90	1854	189	187	187
query91	146	113	115	113
query92	70	50	51	50
query93	3997	513	508	508
query94	1166	220	215	215
query95	418	327	320	320
query96	610	262	265	262
query97	3168	3194	3002	3002
query98	222	201	195	195
query99	1171	850	814	814
Total cold run time: 290761 ms
Total hot run time: 172948 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.71 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f2419eb9943bb9e8cfa7d9d8d1a80d911b4415c3, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.22	0.06	0.06
query4	1.66	0.09	0.10
query5	0.52	0.50	0.50
query6	1.13	0.72	0.72
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.54	0.49	0.49
query10	0.54	0.53	0.55
query11	0.15	0.11	0.11
query12	0.15	0.13	0.12
query13	0.59	0.59	0.58
query14	0.76	0.79	0.78
query15	0.84	0.81	0.82
query16	0.36	0.35	0.35
query17	0.93	1.00	0.97
query18	0.24	0.24	0.25
query19	1.76	1.66	1.71
query20	0.03	0.01	0.01
query21	15.41	0.75	0.66
query22	4.59	7.00	2.15
query23	18.28	1.46	1.23
query24	2.11	0.22	0.23
query25	0.14	0.08	0.08
query26	0.30	0.21	0.21
query27	0.46	0.22	0.22
query28	13.29	1.02	1.00
query29	12.63	3.32	3.25
query30	0.25	0.06	0.06
query31	2.88	0.40	0.39
query32	3.25	0.47	0.47
query33	2.90	2.89	2.86
query34	17.00	4.34	4.30
query35	4.53	4.41	4.41
query36	0.66	0.48	0.47
query37	0.18	0.15	0.15
query38	0.15	0.15	0.14
query39	0.05	0.04	0.04
query40	0.15	0.14	0.14
query41	0.09	0.05	0.04
query42	0.05	0.05	0.04
query43	0.04	0.05	0.04
Total cold run time: 110 s
Total hot run time: 30.71 s

Copy link
Contributor

@zclllyybb zclllyybb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Jul 5, 2024

PR approved by anyone and no changes requested.

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit beb42a0 into apache:master Jul 7, 2024
28 of 30 checks passed
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 7, 2024
Copy link
Contributor

github-actions bot commented Jul 7, 2024

PR approved by at least one committer and no changes requested.

morrySnow added a commit that referenced this pull request Jul 8, 2024
…37360) (#37367)

pick from master #37360

when enable datev1, we should return datev1/datetimev1
dataroaring pushed a commit that referenced this pull request Jul 17, 2024
…37360)

when enable datev1, we should return datev1/datetimev1
@morrySnow morrySnow deleted the fix_datev1_str_to_date branch September 18, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.5-merged dev/3.0.1-merged p0_c reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants