Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](hudi) return empty if there is no commit implemented #37702

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

AshinGau
Copy link
Member

Proposed changes

Return empty set when there is no commit implemented, instead of throwing error:

HoodieException("No instants to incrementally pull")

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@AshinGau
Copy link
Member Author

run buildall

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

the test case will be added later

Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 12, 2024
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 41920 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8af3a0b206e7a4dd2c7da35eb8e38cd16e2102b9, data reload: false

------ Round 1 ----------------------------------
q1	18775	4941	4789	4789
q2	2555	195	192	192
q3	10991	1375	1216	1216
q4	10582	874	862	862
q5	7603	2913	2838	2838
q6	247	139	139	139
q7	1056	618	611	611
q8	9265	2241	2266	2241
q9	8945	6976	6980	6976
q10	8876	3918	3914	3914
q11	461	240	237	237
q12	428	233	238	233
q13	17753	2990	2978	2978
q14	287	236	225	225
q15	522	469	490	469
q16	497	388	375	375
q17	1012	800	625	625
q18	8306	7497	7553	7497
q19	4560	1691	1589	1589
q20	729	339	345	339
q21	5161	3238	4247	3238
q22	399	342	337	337
Total cold run time: 119010 ms
Total hot run time: 41920 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4730	4684	4645	4645
q2	402	274	273	273
q3	3182	2917	2849	2849
q4	2016	1641	1659	1641
q5	5439	5462	5461	5461
q6	242	133	129	129
q7	2201	1717	1697	1697
q8	3393	3623	3621	3621
q9	8550	8497	8524	8497
q10	4032	3793	3906	3793
q11	623	498	487	487
q12	832	624	627	624
q13	16431	3019	2987	2987
q14	317	265	267	265
q15	525	481	480	480
q16	488	407	418	407
q17	1946	1553	1552	1552
q18	7737	7510	7422	7422
q19	6003	1731	1718	1718
q20	2062	1785	1759	1759
q21	5093	4898	4978	4898
q22	596	557	544	544
Total cold run time: 76840 ms
Total hot run time: 55749 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 174650 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8af3a0b206e7a4dd2c7da35eb8e38cd16e2102b9, data reload: false

query1	917	369	363	363
query2	6461	2491	2301	2301
query3	6669	223	225	223
query4	28307	17598	17400	17400
query5	4171	471	490	471
query6	267	157	182	157
query7	4591	308	290	290
query8	301	290	300	290
query9	8567	2466	2472	2466
query10	443	285	287	285
query11	10792	10337	10300	10300
query12	135	85	83	83
query13	1647	379	376	376
query14	10100	7587	7747	7587
query15	251	190	189	189
query16	7732	332	319	319
query17	1762	563	548	548
query18	1783	289	283	283
query19	188	155	162	155
query20	92	80	83	80
query21	208	135	134	134
query22	4684	4380	4261	4261
query23	33724	33146	33285	33146
query24	12027	2883	2915	2883
query25	655	356	379	356
query26	1776	149	145	145
query27	2989	272	274	272
query28	7777	2105	2102	2102
query29	1073	636	592	592
query30	283	147	146	146
query31	936	723	754	723
query32	97	52	56	52
query33	775	291	291	291
query34	978	484	496	484
query35	675	594	561	561
query36	1098	890	929	890
query37	285	79	80	79
query38	2878	2718	2752	2718
query39	875	786	818	786
query40	282	120	117	117
query41	50	51	50	50
query42	118	98	98	98
query43	574	555	532	532
query44	1160	721	726	721
query45	192	166	162	162
query46	1095	725	714	714
query47	1838	1789	1808	1789
query48	368	298	296	296
query49	1204	410	397	397
query50	783	397	393	393
query51	6907	6720	6804	6720
query52	109	87	96	87
query53	357	297	289	289
query54	968	449	450	449
query55	78	76	75	75
query56	308	258	265	258
query57	1186	1057	1061	1057
query58	271	238	248	238
query59	3344	3012	3081	3012
query60	303	281	286	281
query61	99	92	91	91
query62	844	662	655	655
query63	315	290	285	285
query64	10437	2209	1665	1665
query65	3159	3094	3067	3067
query66	1342	332	327	327
query67	15836	15013	14930	14930
query68	4529	564	557	557
query69	471	325	316	316
query70	1187	1132	1155	1132
query71	414	278	281	278
query72	7192	5435	5831	5435
query73	743	335	330	330
query74	6081	5547	5588	5547
query75	3363	2662	2692	2662
query76	2817	990	917	917
query77	488	309	304	304
query78	10321	9275	9774	9275
query79	2274	531	538	531
query80	2190	467	468	467
query81	591	219	221	219
query82	762	140	135	135
query83	291	171	170	170
query84	276	95	98	95
query85	2130	302	291	291
query86	482	323	324	323
query87	3292	3123	3140	3123
query88	3762	2461	2536	2461
query89	486	401	391	391
query90	1842	203	194	194
query91	136	101	103	101
query92	68	50	50	50
query93	2222	518	518	518
query94	1097	216	214	214
query95	399	313	313	313
query96	605	280	275	275
query97	3273	3041	3021	3021
query98	217	201	219	201
query99	1559	1264	1262	1262
Total cold run time: 288056 ms
Total hot run time: 174650 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.96 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8af3a0b206e7a4dd2c7da35eb8e38cd16e2102b9, data reload: false

query1	0.04	0.03	0.04
query2	0.08	0.04	0.04
query3	0.22	0.04	0.05
query4	1.68	0.07	0.07
query5	0.52	0.48	0.49
query6	1.14	0.73	0.72
query7	0.02	0.01	0.01
query8	0.06	0.05	0.05
query9	0.56	0.49	0.50
query10	0.55	0.55	0.55
query11	0.15	0.12	0.11
query12	0.15	0.13	0.13
query13	0.60	0.59	0.58
query14	0.76	0.78	0.76
query15	0.85	0.81	0.82
query16	0.37	0.37	0.35
query17	1.02	0.98	0.99
query18	0.22	0.23	0.23
query19	1.78	1.72	1.69
query20	0.01	0.01	0.02
query21	15.40	0.77	0.65
query22	3.43	6.44	2.34
query23	18.25	1.43	1.26
query24	2.17	0.24	0.22
query25	0.15	0.08	0.09
query26	0.29	0.21	0.21
query27	0.45	0.23	0.22
query28	13.24	1.01	1.00
query29	12.59	3.33	3.30
query30	0.25	0.06	0.06
query31	2.87	0.38	0.40
query32	3.27	0.48	0.46
query33	2.90	2.88	2.95
query34	16.91	4.38	4.31
query35	4.40	4.42	4.45
query36	0.64	0.46	0.46
query37	0.19	0.15	0.15
query38	0.16	0.16	0.15
query39	0.04	0.04	0.03
query40	0.14	0.12	0.13
query41	0.09	0.05	0.05
query42	0.06	0.05	0.04
query43	0.04	0.04	0.04
Total cold run time: 108.71 s
Total hot run time: 30.96 s

@morningman morningman merged commit fa43afc into apache:master Jul 12, 2024
27 of 30 checks passed
seawinde pushed a commit to seawinde/doris that referenced this pull request Jul 17, 2024
)

## Proposed changes

Return empty set when there is no commit implemented, instead of
throwing error:
```
HoodieException("No instants to incrementally pull")
```
dataroaring pushed a commit that referenced this pull request Jul 17, 2024
## Proposed changes

Return empty set when there is no commit implemented, instead of
throwing error:
```
HoodieException("No instants to incrementally pull")
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.5-merged dev/3.0.1-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants