[fix](sink) The issue with 2GB limit of protocol buffer #37990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
yiguolei
reviewed
Jul 17, 2024
| @@ -80,6 +81,13 @@ void GetResultBatchCtx::on_data(const std::unique_ptr<TFetchDataResult>& t_resul | |||
| result->set_packet_seq(packet_seq); | |||
| result->set_eos(eos); | |||
| } | |||
|
|
|||
| /// The size limit of proto buffer message is 2G | |||
| if (result->ByteSizeLong() > std::numeric_limits<int32_t>::max()) { | |||
There was a problem hiding this comment.
2G should be a config.
Set it to 1G.
TPC-H: Total hot run time: 40079 ms |
TPC-DS: Total hot run time: 173515 ms |
ClickBench: Total hot run time: 31 s |
yiguolei
reviewed
Jul 19, 2024
| Block block; | ||
| RETURN_IF_ERROR(VExprContext::get_output_block_after_execute_exprs(_output_vexpr_ctxs, | ||
| input_block, &block)); | ||
| constexpr static size_t MAX_BLOCK_SIZE = 1024L * 1024 * 1024; |
There was a problem hiding this comment.
change the default value to 128MB
|
run buildall |
yiguolei
approved these changes
Jul 19, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 40073 ms |
TPC-DS: Total hot run time: 172333 ms |
ClickBench: Total hot run time: 31.04 s |
zclllyybb
approved these changes
Jul 22, 2024
dataroaring
pushed a commit
that referenced
this pull request
Jul 24, 2024
## Proposed changes ``` Fail to serialize doris.PFetchDataResult ``` If the size of `PFetchDataResult` is greater than 2G, protocol buffer cannot serialize the message.
mrhhsg
added a commit
to mrhhsg/doris
that referenced
this pull request
Aug 8, 2024
``` Fail to serialize doris.PFetchDataResult ``` If the size of `PFetchDataResult` is greater than 2G, protocol buffer cannot serialize the message.
mrhhsg
added a commit
to mrhhsg/doris
that referenced
this pull request
Aug 8, 2024
``` Fail to serialize doris.PFetchDataResult ``` If the size of `PFetchDataResult` is greater than 2G, protocol buffer cannot serialize the message.
yiguolei
pushed a commit
that referenced
this pull request
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
If the size of
PFetchDataResultis greater than 2G, protocol buffer cannot serialize the message.