Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](cloud) Ensure that the eror log has been uploaded to S3 before returning an error URL to the user #38359

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

liaoxin01
Copy link
Contributor

@liaoxin01 liaoxin01 commented Jul 25, 2024

No description provided.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@liaoxin01
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 40110 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 55208846a86b386c1969cde484bd7e26c33f23e8, data reload: false

------ Round 1 ----------------------------------
q1	18223	5424	4451	4451
q2	2828	194	191	191
q3	11108	1296	1031	1031
q4	11173	755	895	755
q5	7806	2762	2744	2744
q6	227	140	138	138
q7	988	601	589	589
q8	9208	2086	2124	2086
q9	8688	6578	6602	6578
q10	8603	3786	3849	3786
q11	472	231	235	231
q12	396	222	225	222
q13	17780	2995	2955	2955
q14	284	247	237	237
q15	532	473	486	473
q16	504	386	397	386
q17	978	613	628	613
q18	8115	7555	7471	7471
q19	7026	1410	1398	1398
q20	676	327	330	327
q21	4975	3169	3221	3169
q22	337	279	281	279
Total cold run time: 120927 ms
Total hot run time: 40110 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4388	4408	4225	4225
q2	381	267	273	267
q3	3025	2783	2753	2753
q4	1939	1664	1600	1600
q5	5332	5360	5321	5321
q6	222	127	131	127
q7	2142	1745	1727	1727
q8	3191	3358	3308	3308
q9	8397	8371	8401	8371
q10	3911	3685	3665	3665
q11	586	490	504	490
q12	769	610	569	569
q13	17620	2978	3049	2978
q14	326	273	271	271
q15	512	468	467	467
q16	481	412	427	412
q17	1778	1476	1472	1472
q18	7781	7450	7456	7450
q19	1646	1382	1507	1382
q20	1993	1796	1782	1782
q21	4925	4759	4716	4716
q22	564	493	476	476
Total cold run time: 71909 ms
Total hot run time: 53829 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173066 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 55208846a86b386c1969cde484bd7e26c33f23e8, data reload: false

query1	928	385	361	361
query2	6445	1885	1815	1815
query3	6664	211	214	211
query4	27519	17329	17346	17329
query5	4241	479	469	469
query6	265	185	159	159
query7	4587	291	280	280
query8	235	197	198	197
query9	8391	2419	2389	2389
query10	441	294	275	275
query11	11812	10146	10044	10044
query12	145	83	89	83
query13	1643	381	369	369
query14	10273	7885	7697	7697
query15	215	167	165	165
query16	7630	470	505	470
query17	1612	553	551	551
query18	1526	287	283	283
query19	208	152	160	152
query20	93	82	83	82
query21	210	134	127	127
query22	4190	4121	3980	3980
query23	33830	33304	33169	33169
query24	11970	2857	2869	2857
query25	660	390	395	390
query26	1752	151	150	150
query27	2765	272	283	272
query28	7404	2029	2021	2021
query29	1048	666	634	634
query30	288	151	153	151
query31	970	736	741	736
query32	101	54	54	54
query33	785	356	337	337
query34	895	474	484	474
query35	867	740	737	737
query36	1095	922	922	922
query37	258	79	81	79
query38	2849	2789	2758	2758
query39	854	813	855	813
query40	284	122	121	121
query41	48	46	48	46
query42	127	97	104	97
query43	498	468	458	458
query44	1306	728	736	728
query45	214	179	179	179
query46	1097	780	744	744
query47	1861	1790	1797	1790
query48	369	293	298	293
query49	1272	409	408	408
query50	780	395	390	390
query51	6839	6596	6694	6596
query52	101	96	90	90
query53	363	289	290	289
query54	976	442	448	442
query55	77	72	75	72
query56	281	271	266	266
query57	1209	1071	1061	1061
query58	267	256	240	240
query59	2791	2571	2550	2550
query60	306	278	283	278
query61	96	97	97	97
query62	838	663	667	663
query63	320	301	290	290
query64	10496	2208	1686	1686
query65	3193	3108	3096	3096
query66	1292	364	329	329
query67	15629	15077	14830	14830
query68	8511	554	563	554
query69	691	460	357	357
query70	1218	1153	1151	1151
query71	527	284	270	270
query72	8920	5764	5476	5476
query73	1306	325	322	322
query74	6161	5768	5724	5724
query75	4592	2671	2743	2671
query76	4987	910	946	910
query77	745	306	297	297
query78	9592	9233	8933	8933
query79	8160	521	519	519
query80	1022	481	485	481
query81	599	222	218	218
query82	292	133	130	130
query83	300	168	160	160
query84	272	92	84	84
query85	1034	309	346	309
query86	355	313	339	313
query87	3339	3106	3120	3106
query88	4790	2372	2373	2372
query89	522	389	376	376
query90	2074	197	192	192
query91	129	104	100	100
query92	64	51	50	50
query93	5845	517	510	510
query94	1338	283	258	258
query95	410	319	312	312
query96	607	271	271	271
query97	3216	3077	3038	3038
query98	223	209	188	188
query99	1552	1243	1297	1243
Total cold run time: 303987 ms
Total hot run time: 173066 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.25 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 55208846a86b386c1969cde484bd7e26c33f23e8, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.04	0.03
query3	0.22	0.05	0.05
query4	1.67	0.07	0.07
query5	0.50	0.49	0.49
query6	1.13	0.73	0.73
query7	0.02	0.01	0.01
query8	0.05	0.05	0.05
query9	0.55	0.48	0.50
query10	0.54	0.55	0.54
query11	0.15	0.11	0.11
query12	0.15	0.13	0.13
query13	0.60	0.58	0.58
query14	0.77	0.79	0.76
query15	0.85	0.82	0.81
query16	0.36	0.37	0.36
query17	0.95	0.95	0.97
query18	0.22	0.21	0.21
query19	1.83	1.76	1.70
query20	0.02	0.01	0.01
query21	15.40	0.76	0.66
query22	4.00	6.59	1.49
query23	18.26	1.45	1.30
query24	2.19	0.23	0.22
query25	0.15	0.08	0.08
query26	0.31	0.22	0.21
query27	0.46	0.23	0.23
query28	13.35	1.01	1.00
query29	12.68	3.30	3.29
query30	0.25	0.06	0.05
query31	2.89	0.39	0.38
query32	3.25	0.47	0.46
query33	2.91	2.93	2.91
query34	17.02	4.39	4.39
query35	4.47	4.42	4.43
query36	0.66	0.47	0.46
query37	0.19	0.16	0.15
query38	0.16	0.16	0.15
query39	0.04	0.04	0.04
query40	0.16	0.13	0.14
query41	0.10	0.04	0.04
query42	0.05	0.05	0.05
query43	0.04	0.04	0.04
Total cold run time: 109.68 s
Total hot run time: 30.25 s

@liaoxin01
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 25, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 39729 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c693aab1aaa928f5cb0930bba63e0cbf954cd3ef, data reload: false

------ Round 1 ----------------------------------
q1	18242	4714	4403	4403
q2	2829	206	205	205
q3	10991	1291	1070	1070
q4	11110	722	752	722
q5	7625	2798	2734	2734
q6	225	141	142	141
q7	991	636	612	612
q8	9225	1928	1898	1898
q9	8783	6587	6589	6587
q10	8697	3869	3815	3815
q11	447	242	250	242
q12	403	233	226	226
q13	17772	2988	3011	2988
q14	278	239	242	239
q15	514	485	505	485
q16	496	399	391	391
q17	960	675	679	675
q18	8154	7524	7409	7409
q19	3471	1034	965	965
q20	683	329	331	329
q21	5062	3447	3312	3312
q22	351	285	281	281
Total cold run time: 117309 ms
Total hot run time: 39729 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4449	4259	4293	4259
q2	376	272	262	262
q3	3042	2796	2746	2746
q4	1926	1610	1598	1598
q5	5307	5344	5343	5343
q6	217	133	131	131
q7	2131	1750	1749	1749
q8	3261	3377	3342	3342
q9	8473	8470	8432	8432
q10	3927	3684	3705	3684
q11	589	501	492	492
q12	767	609	597	597
q13	17546	3009	2987	2987
q14	304	271	273	271
q15	516	492	478	478
q16	484	420	433	420
q17	1826	1477	1474	1474
q18	7795	7434	7553	7434
q19	1677	1601	1674	1601
q20	2000	1791	1780	1780
q21	4856	4568	4632	4568
q22	572	503	510	503
Total cold run time: 72041 ms
Total hot run time: 54151 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173577 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c693aab1aaa928f5cb0930bba63e0cbf954cd3ef, data reload: false

query1	918	369	368	368
query2	6444	1956	1819	1819
query3	6662	205	219	205
query4	28415	17500	17364	17364
query5	4154	495	482	482
query6	262	176	165	165
query7	4583	309	294	294
query8	240	204	198	198
query9	8459	2425	2410	2410
query10	455	283	272	272
query11	11643	10068	10044	10044
query12	137	93	85	85
query13	1640	381	375	375
query14	10352	7873	7703	7703
query15	213	170	172	170
query16	7683	500	501	500
query17	1618	569	553	553
query18	1893	295	295	295
query19	192	154	147	147
query20	96	88	87	87
query21	216	106	101	101
query22	4240	4255	4031	4031
query23	33858	34518	33894	33894
query24	12338	2916	2979	2916
query25	575	396	399	396
query26	1303	155	152	152
query27	2867	275	272	272
query28	7342	2026	2024	2024
query29	682	440	431	431
query30	293	148	151	148
query31	988	740	746	740
query32	93	53	55	53
query33	795	345	345	345
query34	910	465	485	465
query35	869	756	725	725
query36	1118	927	951	927
query37	141	81	84	81
query38	2806	2796	2722	2722
query39	867	813	825	813
query40	268	116	115	115
query41	52	49	46	46
query42	123	96	109	96
query43	501	463	466	463
query44	1252	727	728	727
query45	297	176	174	174
query46	1099	725	716	716
query47	1870	1770	1775	1770
query48	376	317	284	284
query49	1109	401	410	401
query50	815	414	405	405
query51	6739	6737	6557	6557
query52	93	98	87	87
query53	255	177	181	177
query54	847	442	450	442
query55	88	76	75	75
query56	286	268	274	268
query57	1184	1088	1032	1032
query58	269	266	265	265
query59	2735	2703	2572	2572
query60	313	299	300	299
query61	94	96	96	96
query62	805	661	651	651
query63	212	180	179	179
query64	10523	2267	1683	1683
query65	3191	3114	3082	3082
query66	992	337	335	335
query67	15791	15128	15011	15011
query68	8881	573	577	573
query69	733	402	325	325
query70	1444	1112	1162	1112
query71	536	303	265	265
query72	8564	5433	5657	5433
query73	2242	338	331	331
query74	6222	5626	5658	5626
query75	4727	2660	2686	2660
query76	5398	937	901	901
query77	755	339	329	329
query78	9762	9048	8977	8977
query79	8580	526	517	517
query80	1222	490	500	490
query81	588	219	225	219
query82	551	142	131	131
query83	348	174	230	174
query84	271	94	81	81
query85	1162	321	307	307
query86	365	325	289	289
query87	3377	3128	3139	3128
query88	4503	2423	2410	2410
query89	522	288	288	288
query90	2130	201	199	199
query91	128	103	101	101
query92	64	52	49	49
query93	6948	544	544	544
query94	1127	337	283	283
query95	353	259	263	259
query96	616	279	274	274
query97	3187	3053	3066	3053
query98	210	204	190	190
query99	1579	1279	1287	1279
Total cold run time: 307634 ms
Total hot run time: 173577 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.54 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c693aab1aaa928f5cb0930bba63e0cbf954cd3ef, data reload: false

query1	0.05	0.04	0.03
query2	0.08	0.04	0.05
query3	0.22	0.05	0.05
query4	1.67	0.08	0.08
query5	0.49	0.50	0.47
query6	1.14	0.72	0.72
query7	0.03	0.01	0.01
query8	0.05	0.04	0.04
query9	0.55	0.49	0.49
query10	0.54	0.54	0.54
query11	0.16	0.11	0.11
query12	0.15	0.12	0.13
query13	0.60	0.59	0.58
query14	0.79	0.78	0.78
query15	0.85	0.80	0.82
query16	0.37	0.37	0.35
query17	1.01	1.04	1.02
query18	0.22	0.22	0.23
query19	1.79	1.68	1.76
query20	0.01	0.01	0.01
query21	15.40	0.80	0.67
query22	4.01	7.80	1.76
query23	18.30	1.37	1.32
query24	2.06	0.22	0.23
query25	0.15	0.10	0.07
query26	0.31	0.20	0.21
query27	0.46	0.23	0.23
query28	13.30	1.02	0.99
query29	12.63	3.32	3.30
query30	0.25	0.06	0.05
query31	2.86	0.40	0.39
query32	3.26	0.48	0.46
query33	2.88	2.95	2.90
query34	16.83	4.36	4.35
query35	4.44	4.45	4.44
query36	0.64	0.48	0.46
query37	0.18	0.16	0.15
query38	0.16	0.15	0.16
query39	0.05	0.03	0.03
query40	0.15	0.12	0.12
query41	0.10	0.05	0.05
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 109.3 s
Total hot run time: 30.54 s

@dataroaring dataroaring merged commit 38d1b84 into apache:master Jul 26, 2024
27 of 30 checks passed
dataroaring pushed a commit that referenced this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.1-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants