Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](nereids) fix insert stmt throw MultiCastDataSink cannot be cast to DataStreamSink #38526

Merged
merged 3 commits into from
Jul 30, 2024
Merged

[fix](nereids) fix insert stmt throw MultiCastDataSink cannot be cast to DataStreamSink #38526

merged 3 commits into from
Jul 30, 2024

Conversation

924060929
Copy link
Contributor

@924060929 924060929 commented Jul 30, 2024 •
edited
Loading

Proposed changes

fix insert ... with ... select ..., which not use some cte, and throw an exception:

errCode = 2, detailMessage = class org.apache.doris.planner.MultiCastDataSink cannot be cast to class org.apache.doris.planner.DataStreamSink (org.apache.doris.planner.MultiCastDataSink and org.apache.doris.planner.DataStreamSink are in unnamed module of loader 'app')

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@924060929
Copy link
Contributor Author

run buildall

@924060929
Copy link
Contributor Author

run buildall

@924060929 924060929 changed the title [fix](nereids) fix insert stmt throw [fix](nereids) fix insert stmt throw MultiCastDataSink cannot be cast to DataStreamSink Jul 30, 2024
@morrySnow morrySnow added dev/2.1.x usercase Important user case type label p0_b labels Jul 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 41239 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 116a1c295da067ced45274bcbaac3722439b6eb1, data reload: false

------ Round 1 ----------------------------------
q1	18154	4137	4107	4107
q2	3141	213	210	210
q3	11088	1279	1297	1279
q4	10555	823	917	823
q5	7860	2885	3012	2885
q6	227	140	138	138
q7	1037	612	624	612
q8	9433	1817	1926	1817
q9	8558	6576	6565	6565
q10	8672	3808	3813	3808
q11	426	251	245	245
q12	404	222	220	220
q13	17767	2909	2947	2909
q14	269	238	245	238
q15	531	482	491	482
q16	485	405	381	381
q17	967	924	913	913
q18	7979	7385	7163	7163
q19	1390	1217	1207	1207
q20	568	321	330	321
q21	5205	4645	4742	4645
q22	359	283	271	271
Total cold run time: 115075 ms
Total hot run time: 41239 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4049	4172	3997	3997
q2	342	220	215	215
q3	2964	2999	2975	2975
q4	1849	1831	1864	1831
q5	5264	5186	5204	5186
q6	212	128	129	128
q7	2061	1695	1719	1695
q8	3201	3298	3226	3226
q9	8289	8225	8266	8225
q10	3733	3860	3825	3825
q11	539	443	452	443
q12	712	573	548	548
q13	11924	2920	2930	2920
q14	284	252	251	251
q15	520	475	475	475
q16	439	404	398	398
q17	1730	1700	1686	1686
q18	7738	7501	7231	7231
q19	1676	1652	1656	1652
q20	1943	1758	1748	1748
q21	5479	5232	5215	5215
q22	522	445	451	445
Total cold run time: 65470 ms
Total hot run time: 54315 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 169691 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 116a1c295da067ced45274bcbaac3722439b6eb1, data reload: false

query1	914	378	373	373
query2	6475	1741	1772	1741
query3	6656	214	222	214
query4	19573	17357	17368	17357
query5	4301	504	526	504
query6	289	171	158	158
query7	4601	305	294	294
query8	263	196	206	196
query9	8513	2370	2394	2370
query10	429	263	270	263
query11	10415	10037	10141	10037
query12	136	87	91	87
query13	1602	377	351	351
query14	8888	8099	7747	7747
query15	207	167	157	157
query16	7084	432	459	432
query17	922	542	535	535
query18	1865	282	280	280
query19	191	149	147	147
query20	93	85	88	85
query21	202	121	96	96
query22	4270	3932	3907	3907
query23	33493	33015	33028	33015
query24	10399	3085	2983	2983
query25	690	387	398	387
query26	1813	153	153	153
query27	2984	266	265	265
query28	7056	1945	1935	1935
query29	1309	418	407	407
query30	287	147	148	147
query31	943	746	734	734
query32	97	53	57	53
query33	695	303	304	303
query34	894	462	474	462
query35	857	718	713	713
query36	998	830	876	830
query37	300	78	80	78
query38	2858	2770	2760	2760
query39	875	808	803	803
query40	287	110	118	110
query41	49	47	46	46
query42	118	103	109	103
query43	494	442	436	436
query44	1221	726	719	719
query45	205	175	180	175
query46	1082	787	775	775
query47	1824	1745	1720	1720
query48	360	293	283	283
query49	1198	419	416	416
query50	906	438	444	438
query51	6746	6694	6684	6684
query52	104	92	93	92
query53	252	178	175	175
query54	625	452	460	452
query55	74	76	76	76
query56	265	263	259	259
query57	1119	1043	1060	1043
query58	296	269	280	269
query59	2737	2447	2602	2447
query60	312	297	279	279
query61	99	95	94	94
query62	912	658	657	657
query63	215	181	206	181
query64	5957	1898	1871	1871
query65	3144	3075	3074	3074
query66	1445	346	367	346
query67	15651	14912	15072	14912
query68	4334	553	582	553
query69	448	326	303	303
query70	1120	1108	1085	1085
query71	351	274	278	274
query72	7125	2693	2542	2542
query73	774	324	323	323
query74	5979	5677	5659	5659
query75	3334	2731	2746	2731
query76	2288	1341	1416	1341
query77	446	308	315	308
query78	9391	9016	8813	8813
query79	1320	536	524	524
query80	1802	517	507	507
query81	564	225	225	225
query82	1025	135	129	129
query83	290	174	177	174
query84	274	83	79	79
query85	1359	324	377	324
query86	404	290	319	290
query87	3244	3089	3093	3089
query88	2906	2393	2396	2393
query89	389	295	288	288
query90	1811	202	194	194
query91	124	104	102	102
query92	62	49	51	49
query93	1359	611	595	595
query94	931	308	294	294
query95	379	265	266	265
query96	601	278	276	276
query97	3217	3018	2990	2990
query98	213	201	203	201
query99	1635	1280	1289	1280
Total cold run time: 261633 ms
Total hot run time: 169691 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.05 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 116a1c295da067ced45274bcbaac3722439b6eb1, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.04	0.04
query3	0.23	0.04	0.04
query4	1.68	0.07	0.07
query5	0.49	0.48	0.48
query6	1.17	0.71	0.72
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.56	0.49	0.51
query10	0.58	0.57	0.57
query11	0.15	0.11	0.12
query12	0.15	0.12	0.12
query13	0.60	0.60	0.59
query14	0.78	0.80	0.79
query15	0.88	0.86	0.86
query16	0.36	0.34	0.36
query17	1.01	1.01	1.02
query18	0.23	0.21	0.21
query19	1.82	1.73	1.72
query20	0.01	0.01	0.01
query21	15.39	0.77	0.65
query22	3.85	7.42	1.52
query23	18.05	1.33	1.27
query24	2.26	0.23	0.22
query25	0.18	0.09	0.07
query26	0.32	0.22	0.21
query27	0.46	0.23	0.23
query28	13.16	0.99	0.97
query29	12.52	3.32	3.30
query30	0.26	0.06	0.06
query31	2.88	0.40	0.40
query32	3.24	0.49	0.47
query33	2.91	2.95	2.87
query34	15.45	4.22	4.28
query35	4.29	4.28	4.29
query36	0.67	0.47	0.48
query37	0.20	0.17	0.16
query38	0.16	0.15	0.14
query39	0.04	0.04	0.04
query40	0.15	0.12	0.13
query41	0.09	0.05	0.06
query42	0.05	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 107.51 s
Total hot run time: 30.05 s

@924060929 924060929 merged commit a55af3b into apache:master Jul 30, 2024
31 of 33 checks passed
924060929 added a commit to 924060929/incubator-doris that referenced this pull request Jul 30, 2024
@924060929
[fix](nereids) fix insert stmt throw MultiCastDataSink cannot be cast…
67491a0 
… to DataStreamSink (apache#38526)

fix `insert ... with ... select ...`, which not use some cte, and throw
an exception:
```
errCode = 2, detailMessage = class org.apache.doris.planner.MultiCastDataSink cannot be cast to class org.apache.doris.planner.DataStreamSink (org.apache.doris.planner.MultiCastDataSink and org.apache.doris.planner.DataStreamSink are in unnamed module of loader 'app')
```

(cherry picked from commit a55af3b)
@924060929 924060929 mentioned this pull request Jul 30, 2024
Merged
924060929 added a commit that referenced this pull request Jul 30, 2024
@924060929
[fix](nereids) fix insert stmt throw MultiCastDataSink cannot be cast…
a328e01 
… to DataStreamSink (#38526) (#38547)

fix `insert ... with ... select ...`, which not use some cte, and throw an exception:
```
errCode = 2, detailMessage = class org.apache.doris.planner.MultiCastDataSink cannot be cast to class org.apache.doris.planner.DataStreamSink (org.apache.doris.planner.MultiCastDataSink and org.apache.doris.planner.DataStreamSink are in unnamed module of loader 'app')
```
dataroaring pushed a commit that referenced this pull request Jul 31, 2024
@924060929 @dataroaring
[fix](nereids) fix insert stmt throw MultiCastDataSink cannot be cast…
6c41b50 
… to DataStreamSink (#38526)

fix `insert ... with ... select ...`, which not use some cte, and throw
an exception:
```
errCode = 2, detailMessage = class org.apache.doris.planner.MultiCastDataSink cannot be cast to class org.apache.doris.planner.DataStreamSink (org.apache.doris.planner.MultiCastDataSink and org.apache.doris.planner.DataStreamSink are in unnamed module of loader 'app')
```
feiniaofeiafei pushed a commit to feiniaofeiafei/doris that referenced this pull request Aug 9, 2024
@924060929 @feiniaofeiafei
[fix](nereids) fix insert stmt throw MultiCastDataSink cannot be cast…
6ac4996 
… to DataStreamSink (apache#38526)

fix `insert ... with ... select ...`, which not use some cte, and throw
an exception:
```
errCode = 2, detailMessage = class org.apache.doris.planner.MultiCastDataSink cannot be cast to class org.apache.doris.planner.DataStreamSink (org.apache.doris.planner.MultiCastDataSink and org.apache.doris.planner.DataStreamSink are in unnamed module of loader 'app')
```
@gavinchou gavinchou mentioned this pull request Aug 19, 2024
Open
@yiguolei yiguolei mentioned this pull request Sep 5, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starocean999 starocean999 starocean999 approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.6-merged dev/3.0.1-merged p0_b reviewed usercase Important user case type label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@924060929 @doris-robot @starocean999 @morrySnow @dataroaring