Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[branch-2.1](load) fix miss writer in concurrency incremental open (#38605) #38793

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

zclllyybb
Copy link
Contributor

pick #38605

…8605)

Issue Number: close #xxx

fix bugs like:
```log
W20240730 23:06:19.640558 108249 status.h:421] meet error status: [INTERNAL_ERROR]unknown tablet to append data, tablet=17285252124319

	0#  doris::BaseTabletsChannel::_write_block_data(doris::PTabletWriterAddBlockRequest const&, long, std::unordered_map<long, std::vector<unsigned int, std::allocator<unsigned int> >, std::hash<long>, std::equal_to<long>, std::allocator<std::pair<long const, std::vector<unsigned int, std::allocator<unsigned int> > > > >&, doris::PTabletWriterAddBlockResult*) at /root/doris/be/src/common/status.h:0
	1#  doris::CloudTabletsChannel::add_batch(doris::PTabletWriterAddBlockRequest const&, doris::PTabletWriterAddBlockResult*) at /root/doris/be/src/cloud/cloud_tablets_channel.cpp:0
	2#  doris::LoadChannel::add_batch(doris::PTabletWriterAddBlockRequest const&, doris::PTabletWriterAddBlockResult*) at /root/doris/be/src/runtime/load_channel.cpp:179
	3#  doris::LoadChannelMgr::add_batch(doris::PTabletWriterAddBlockRequest const&, doris::PTabletWriterAddBlockResult*) at /root/doris/be/src/runtime/load_channel_mgr.cpp:0
	4#  std::_Function_handler<void (), doris::PInternalService::tablet_writer_add_block(google::protobuf::RpcController*, doris::PTabletWriterAddBlockRequest const*, doris::PTabletWriterAddBlockResult*, google::protobuf::Closure*)::$_0>::_M_invoke(std::_Any_data const&) at /root/doris/be/src/common/status.h:488
	5#  doris::WorkThreadPool<false>::work_thread(int) at /root/doris/be/src/util/work_thread_pool.hpp:159
	6#  execute_native_thread_routine at /data/gcc-11.1.0/build/x86_64-pc-linux-gnu/libstdc++-v3/include/bits/unique_ptr.h:85
	7#  ?
	8#  clone
```
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zclllyybb
Copy link
Contributor Author

run buildall

Copy link
Contributor

github-actions bot commented Aug 2, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.41% (9255/25416)
Line Coverage: 27.95% (75653/270721)
Region Coverage: 26.78% (38892/145252)
Branch Coverage: 23.49% (19728/83972)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a86c9b2db4360bbf29abf162df9dd0dc81aad906_a86c9b2db4360bbf29abf162df9dd0dc81aad906/report/index.html

@yiguolei yiguolei merged commit 8fa0710 into apache:branch-2.1 Aug 5, 2024
19 of 22 checks passed
@yiguolei yiguolei mentioned this pull request Sep 5, 2024
3 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants