[Refactor] Replace some boost to std in OlapScanNode #3934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaoyli
requested changes
Jun 24, 2020
| @@ -186,9 +185,9 @@ Status OlapScanNode::get_next(RuntimeState* state, RowBatch* row_batch, bool* eo | |||
|
|
|||
| // check if Canceled. | |||
| if (state->is_cancelled()) { | |||
| boost::unique_lock<boost::mutex> l(_row_batches_lock); | |||
| std::unique_lock<std::mutex> l(_row_batches_lock); | |||
There was a problem hiding this comment.
You can use util/condition_variable.h.
It comes from kudu, it's use is simple than std::
There was a problem hiding this comment.
This PR is only try to solve the BE crash problem and I don't want to introduce any new potential problems.
I can't see any necessary to replace the std::condition_variable with ConditionVariable. If it is,
maybe we can replace all std::condition_variable in another PR.
chaoyli
approved these changes
Jun 28, 2020
morningman
added a commit
to morningman/doris
that referenced
this pull request
Jun 29, 2020
Replace some boost to std in OlapScanNode. This refactor seems solve the problem describe in apache#3929. Because I found that BE will crash to calling `boost::condition_variable.notify_all()`. But after upgrade to this, BE does not crash any more. Change-Id: I4baeeb6e76ecc751cb042796d52692d79432994e
wuyunfeng
pushed a commit
to wuyunfeng/incubator-doris
that referenced
this pull request
Jun 30, 2020
Replace some boost to std in OlapScanNode. This refactor seems solve the problem describe in apache#3929. Because I found that BE will crash to calling `boost::condition_variable.notify_all()`. But after upgrade to this, BE does not crash any more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace some boost to std in OlapScanNode.
This refactor seems solve the problem describe in #3929.
Because I found that BE will crash to calling
boost::condition_variable.notify_all().But after upgrade to this, BE does not crash any more.