Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve](cloud-mow) splitting large rowset meta into multiple KVs #40059

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hust-hhb
Copy link
Contributor

now large rowset meta save to fdb will fail, it will report error failed to commit rowset: failed to save rowset meta, err=Value length exceeds limit, rowset meta need to split into multiple KVs when value is bigger than 90kb.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@hust-hhb
Copy link
Contributor Author

run buildall

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add ut and regression test.

@gavinchou gavinchou requested a review from w41ter August 29, 2024 15:58
Copy link
Collaborator

@gavinchou gavinchou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implementation is dangerous and not well considered with recycling procedure.
Further discussion should be taken.

@hust-hhb
Copy link
Contributor Author

hust-hhb commented Sep 2, 2024

run buildall

@hust-hhb
Copy link
Contributor Author

hust-hhb commented Sep 2, 2024

run buildall

Copy link
Contributor

github-actions bot commented Sep 2, 2024

clang-tidy review says "All clean, LGTM! 👍"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants