-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve](cloud-mow) splitting large rowset meta into multiple KVs #40059
base: master
Are you sure you want to change the base?
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add ut and regression test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This implementation is dangerous and not well considered with recycling procedure.
Further discussion should be taken.
df3ad16
to
537221f
Compare
run buildall |
537221f
to
489a0e6
Compare
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
now large rowset meta save to fdb will fail, it will report error
failed to commit rowset: failed to save rowset meta, err=Value length exceeds limit
, rowset meta need to split into multiple KVs when value is bigger than 90kb.