-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix](Nereids) fix date and date time arithmatic #40745
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
TPC-H: Total hot run time: 40009 ms
|
TPC-DS: Total hot run time: 194853 ms
|
ClickBench: Total hot run time: 30.69 s
|
a079596
to
374dee2
Compare
run buildall |
374dee2
to
b922cc8
Compare
run buildall |
TPC-H: Total hot run time: 41569 ms
|
TPC-DS: Total hot run time: 195175 ms
|
ClickBench: Total hot run time: 31.84 s
|
run buildall |
TPC-H: Total hot run time: 41860 ms
|
TPC-DS: Total hot run time: 193933 ms
|
ClickBench: Total hot run time: 32.82 s
|
run buildall |
be39b1f
to
e291317
Compare
run buildall |
TPC-H: Total hot run time: 41471 ms
|
TPC-DS: Total hot run time: 199570 ms
|
ClickBench: Total hot run time: 31.97 s
|
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add ut and regression test case please
TPC-DS: Total hot run time: 190867 ms
|
ClickBench: Total hot run time: 32.21 s
|
run cloud_p0 |
secondsAdd = new SecondsAdd(DateV2Literal.fromJavaDateType(LocalDateTime.of(1, 1, 1, 1, 1, 1)), | ||
new IntegerLiteral(1)); | ||
rewritten = executor.rewrite(secondsAdd, context); | ||
Assertions.assertTrue(new DateTimeV2Literal("0001-01-01 00:00:01").compareTo((Literal) rewritten) == 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use assertEquals
Assertions.assertTrue(new DateTimeV2Literal("4084-01-24 02:07:00").compareTo((Literal) rewritten) == 0); | ||
minutesAdd = new MinutesAdd(DateV2Literal.fromJavaDateType(LocalDateTime.of(0, 1, 1, 0, 1, 1)), | ||
new IntegerLiteral(-2)); | ||
rewritten = executor.rewrite(minutesAdd, context); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test overflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
e913f5e
to
7dd2bb1
Compare
run buildall |
TPC-H: Total hot run time: 40917 ms
|
TPC-DS: Total hot run time: 191891 ms
|
ClickBench: Total hot run time: 32.86 s
|
run buildall |
TPC-H: Total hot run time: 40787 ms
|
TPC-DS: Total hot run time: 192375 ms
|
ClickBench: Total hot run time: 32.59 s
|
run external |
PR approved by at least one committer and no changes requested. |
fix date and time arithmatic of: hours_add, minutes_add, seconds_add, to_days
fix date and time arithmatic of: hours_add, minutes_add, seconds_add, to_days
fix date and time arithmatic of: hours_add, minutes_add, seconds_add, to_days
fix date and time arithmatic of: hours_add, minutes_add, seconds_add, to_days
fix date and time arithmatic of: hours_add, minutes_add, seconds_add, to_days