[Fix]unified cancel method in coordinator #41038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
yiguolei
reviewed
Sep 20, 2024
wangbo
force-pushed
the
0920_fix_queue
branch
from
3d1bd01
to
e2ee9c1
Compare
|
run buildall |
wangbo
force-pushed
the
0920_fix_queue
branch
from
8628bc7
to
b03aebb
Compare
|
run buildall |
yiguolei
approved these changes
Sep 21, 2024
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
|
PR approved by anyone and no changes requested. |
zclllyybb
approved these changes
Sep 21, 2024
dataroaring
pushed a commit
that referenced
this pull request
Oct 9, 2024
## Proposed changes Coordinator has two cancel method, with args and without args. They should has the same behavior, so query queue cancel should be moved to cancel method with args.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Coordinator has two cancel method, with args and without args.
They should has the same behavior, so query queue cancel should be moved to cancel method with args.