Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] CTAS create table by partition list #9412

Merged
merged 4 commits into from
May 7, 2022

Conversation

stalary
Copy link
Contributor

@stalary stalary commented May 6, 2022

Proposed changes

Issue Number: close (#9411)

Problem Summary:

Describe the overview of changes.

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@stalary
Copy link
Contributor Author

stalary commented May 6, 2022

PTAL @long2ice @hf200012

@stalary stalary changed the title FIX: CTAS create table by partition list [Bug] CTAS create table by partition list May 6, 2022
hf200012
hf200012 previously approved these changes May 6, 2022
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2022

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2022

PR approved by anyone and no changes requested.

qidaye
qidaye previously approved these changes May 6, 2022
Copy link
Contributor

@qidaye qidaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stalary stalary dismissed stale reviews from qidaye and hf200012 via 38fac77 May 7, 2022 01:07
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label May 7, 2022
Copy link
Contributor

@hf200012 hf200012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2022

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 7, 2022
@yiguolei yiguolei merged commit b6a74cf into apache:master May 7, 2022
starocean999 pushed a commit to starocean999/incubator-doris that referenced this pull request May 19, 2022

Co-authored-by: Rongqian Li <rongqian_li@idgcapital.com>
@stalary stalary deleted the fix/ctas_list_partition branch May 22, 2022 23:38
englefly pushed a commit to englefly/incubator-doris that referenced this pull request May 23, 2022

Co-authored-by: Rongqian Li <rongqian_li@idgcapital.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. kind/behavior-changed reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants