-
Notifications
You must be signed in to change notification settings - Fork 35
Conversation
LGTM 👍 |
You do not need the script part in .travis-file (last lines) as we have a defaultGoal in our pom, which we want Travis CI to use. |
We tested it without it, but because of the way it bootstraps the tests, the second phase fails in the distribution. So we do need the script part there, or we need to adjust the maven build to cope with this. |
@ottlinger you can replicate that actually in your own build by running
which is what Travis runs. I don't think it hurts having the script in for now, I'm sure we can improve it and remove it later if needs be. |
awesome looks great! once we commit this I think we need to contact Apache infra to turn this on. @buggtb or someone else can you take care of that? |
I shall enquire….
On 27 July 2018 at 14:27:56, Chris Mattmann (notifications@github.com) wrote:
Merged #143 <#143>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#143 (comment)>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AAGUePxn8CNepiutfQ-55ghYEp0kmOd_ks5uKxVcgaJpZM4VjXg6>
.
…--
Spicule Limited is registered in England & Wales. Company Number:
09954122. Registered office: First Floor, Telecom House, 125-135 Preston
Road, Brighton, England, BN1 6AF. VAT No. 251478891.
All engagements
are subject to Spicule Terms and Conditions of Business. This email and its
contents are intended solely for the individual to whom it is addressed and
may contain information that is confidential, privileged or otherwise
protected from disclosure, distributing or copying. Any views or opinions
presented in this email are solely those of the author and do not
necessarily represent those of Spicule Limited. The company accepts no
liability for any damage caused by any virus transmitted by this email. If
you have received this message in error, please notify us immediately by
reply email before deleting it from your system. Service of legal notice
cannot be effected on Spicule Limited by email.
|
Filed INFRA-16831 to get it switched on |
👍 sorry - I though I already filed a ticket but seem to have forgotten about it. |
No probs. It’s been done, builds looking good.
On 27 July 2018 at 21:00:56, P. Ottlinger (notifications@github.com) wrote:
👍 sorry - I though I already filed a ticket but seem to have forgotten
about it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#143 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAGUeP3832vCHKJgsRiUCYh4WFAQUYyCks5uK3F3gaJpZM4VjXg6>
.
…--
Spicule Limited is registered in England & Wales. Company Number:
09954122. Registered office: First Floor, Telecom House, 125-135 Preston
Road, Brighton, England, BN1 6AF. VAT No. 251478891.
All engagements
are subject to Spicule Terms and Conditions of Business. This email and its
contents are intended solely for the individual to whom it is addressed and
may contain information that is confidential, privileged or otherwise
protected from disclosure, distributing or copying. Any views or opinions
presented in this email are solely those of the author and do not
necessarily represent those of Spicule Limited. The company accepts no
liability for any damage caused by any virus transmitted by this email. If
you have received this message in error, please notify us immediately by
reply email before deleting it from your system. Service of legal notice
cannot be effected on Spicule Limited by email.
|
Builds look green - perfect ;-) |
I've got Travis CI working for DRAT. Tests are passing now.