Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Set up Travis CI #143

Merged
merged 7 commits into from
Jul 27, 2018
Merged

Set up Travis CI #143

merged 7 commits into from
Jul 27, 2018

Conversation

RyanMcDonagh
Copy link

@RyanMcDonagh RyanMcDonagh commented Jul 27, 2018

I've got Travis CI working for DRAT. Tests are passing now.

@buggtb
Copy link
Contributor

buggtb commented Jul 27, 2018

LGTM 👍

@ottlinger
Copy link
Contributor

You do not need the script part in .travis-file (last lines) as we have a defaultGoal in our pom, which we want Travis CI to use.

@RyanMcDonagh
Copy link
Author

We tested it without it, but because of the way it bootstraps the tests, the second phase fails in the distribution. So we do need the script part there, or we need to adjust the maven build to cope with this.

@buggtb
Copy link
Contributor

buggtb commented Jul 27, 2018

@ottlinger you can replicate that actually in your own build by running

mvn test -B 

which is what Travis runs. I don't think it hurts having the script in for now, I'm sure we can improve it and remove it later if needs be.

@chrismattmann chrismattmann self-assigned this Jul 27, 2018
@chrismattmann chrismattmann added this to the release-1.0 milestone Jul 27, 2018
@chrismattmann
Copy link
Collaborator

awesome looks great! once we commit this I think we need to contact Apache infra to turn this on. @buggtb or someone else can you take care of that?

@chrismattmann chrismattmann merged commit 34d0251 into apache:master Jul 27, 2018
@buggtb
Copy link
Contributor

buggtb commented Jul 27, 2018 via email

@buggtb
Copy link
Contributor

buggtb commented Jul 27, 2018

Filed INFRA-16831 to get it switched on

@ottlinger
Copy link
Contributor

👍 sorry - I though I already filed a ticket but seem to have forgotten about it.

@buggtb
Copy link
Contributor

buggtb commented Jul 27, 2018 via email

@ottlinger
Copy link
Contributor

ottlinger commented Jul 27, 2018

Builds look green - perfect ;-)
https://travis-ci.org/apache/drat

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants