Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRILL-6915: Disable generation of test tables with case-sensitive names for non-Linux systems #1580

Closed
wants to merge 1 commit into from

Conversation

vvysotskyi
Copy link
Member

@vvysotskyi vvysotskyi commented Dec 20, 2018

  • Splited scripts to generate regular tables for tests in one script and tables with a different case in names in another one.
  • Introduced "linux" profile to specify a script which generates tables with names in different case only when the Linux system is used.
  • Disabled test which checks table names case sensitivity for non-Linux systems.
  • Updated hibernate-validator dependency for jcabi-mysql-maven-plugin to fix NoClassDefFoundError error and specified jaxb-api to avoid problems with JDK 9+.
  • Changed driver from com.mysql.jdbc.Driver to com.mysql.cj.jdbc.Driver for tests to avoid warnings (see https://dev.mysql.com/doc/connector-j/8.0/en/connector-j-api-changes.html)

For details please see DRILL-6915.

@arina-ielchiieva
Copy link
Member

Reviewed and tested the fix, looks good, +1.
Once @Ben-Zvi confirms that test fixes the issue on his env, PR is good to go.

@asfgit asfgit closed this in 6a9465a Dec 20, 2018
mattpollack pushed a commit to mattpollack/drill that referenced this pull request Feb 25, 2019
karthik-man pushed a commit to karthik-man/drill that referenced this pull request Mar 14, 2019
lushuifeng pushed a commit to lushuifeng/drill that referenced this pull request Jun 21, 2019
xiangt920 pushed a commit to xiangt920/drill that referenced this pull request Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants