DRILL-7380: Query of a field inside of an array of structs returns null #1861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KazydubB please review. |
KazydubB
reviewed
Sep 26, 2019
logical/src/main/java/org/apache/drill/common/expression/SchemaPath.java
Show resolved
Hide resolved
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet2/DrillParquetReader.java
Outdated
Show resolved
Hide resolved
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet2/DrillParquetReader.java
Outdated
Show resolved
Hide resolved
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet2/DrillParquetReader.java
Outdated
Show resolved
Hide resolved
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet2/DrillParquetReader.java
Outdated
Show resolved
Hide resolved
|
@KazydubB , I've addressed comments, please check again. |
1. Fixed parquet reader projection for Logical lists (DrillParquetReader.java) 2. Fixed projection pushdown for RexFieldAccess (ProjectFieldsVisitor.java) 3. DrillParquetReader.getProjection(...) splitted into few methods 4. Added javadocs for PathSegment and SchemaPath
ihuzenko
force-pushed
the
DRILL-7380
branch
from
9d70221
to
76aad49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covers DRILL-7380 and DRILL-7381 jira tickets.